subprocess: replace __USING_WINDOWS__ with WIN32#34733
Merged
hebasto merged 1 commit intobitcoin:masterfrom Mar 5, 2026
Merged
subprocess: replace __USING_WINDOWS__ with WIN32#34733hebasto merged 1 commit intobitcoin:masterfrom
hebasto merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
sedited
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivated by #34385 (review)
In
subprocess.hwe are now renaming__USING_WINDOWS__withWIN32In the rest of the codebase, we are using
WIN32, so it makes sense to updatesubprocess.hto match that.Use the following
grepto assert there is no__USING_WINDOWS__in the codebase