Skip to content

ci: Set TEST_RUNNER_PORT_MIN in test-each after cirrus runner switch#34687

Merged
fanquake merged 2 commits intobitcoin:masterfrom
maflcko:2602-ci-min-port
Feb 27, 2026
Merged

ci: Set TEST_RUNNER_PORT_MIN in test-each after cirrus runner switch#34687
fanquake merged 2 commits intobitcoin:masterfrom
maflcko:2602-ci-min-port

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Feb 27, 2026

This is needed after the recent switch to cirrus runners in the task in commit c8c9c1e.

Otherwise, the CI will fail:

 node1 stderr Error: Unable to bind to 127.0.0.1:12321 on this computer. Bitcoin Core is probably already running.

(https://github.com/bitcoin/bitcoin/actions/runs/22398358349/job/64837827234?pr=31723#step:9:2605)

Also, include a random second commit, so that the CI task is run in this pull.

@DrahtBot DrahtBot changed the title ci: Set TEST_RUNNER_PORT_MIN in test-each after cirrus runner switch ci: Set TEST_RUNNER_PORT_MIN in test-each after cirrus runner switch Feb 27, 2026
@DrahtBot DrahtBot added the Tests label Feb 27, 2026
@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 27, 2026 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK l0rinc, willcl-ark

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

This was referenced Feb 27, 2026
Merged
Open
l0rinc
l0rinc approved these changes Feb 27, 2026
View reviewed changes
Copy link
Contributor

@l0rinc l0rinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa18be2

.github/workflows/ci.yml
needs: runners
runs-on: ${{ needs.runners.outputs.provider == 'cirrus' && 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-md' || 'ubuntu-24.04' }}
env:
TEST_RUNNER_PORT_MIN: "14000" # Use a larger port, to avoid colliding with CIRRUS_CACHE_HOST port 12321.
Copy link
Contributor

@l0rinc l0rinc Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is 11000, right?

Copy link
Contributor

@hodlinator hodlinator Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing CIRRUS_CACHE_HOST to be below 11000 would be a smaller diff in this file... wait - cirruslabs/cirrus-ci-docs#310 I guess we've been down that lane before.

For reference:

bitcoin/.github/workflows/ci.yml

Line 22 in 286de1e

CIRRUS_CACHE_HOST: http://127.0.0.1:12321/ # When using Cirrus Runners this host can be used by the docker `gha` build cache type.

bitcoin/test/functional/test_framework/util.py

Lines 468 to 471 in 286de1e

# Don't assign p2p, rpc or tor ports lower than this
PORT_MIN = int(os.getenv('TEST_RUNNER_PORT_MIN', default=11000))
# The number of ports to "reserve" for p2p, rpc and tor, each
PORT_RANGE = 5000

Copy link
Member Author

@maflcko maflcko Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that cirrus-ci.com is different from cirrus-runners.app. I am not even sure if the runners have any docs on this

@maflcko maflcko added this to the 31.0 milestone Feb 27, 2026
willcl-ark
willcl-ark approved these changes Feb 27, 2026
View reviewed changes
Copy link
Member

@willcl-ark willcl-ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa18be2

@fanquake fanquake merged commit 3a8b4e8 into bitcoin:master Feb 27, 2026
51 of 52 checks passed
hodlinator
hodlinator reviewed Feb 27, 2026
View reviewed changes
Copy link
Contributor

@hodlinator hodlinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa18be2

.github/workflows/ci.yml
needs: runners
runs-on: ${{ needs.runners.outputs.provider == 'cirrus' && 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-md' || 'ubuntu-24.04' }}
env:
TEST_RUNNER_PORT_MIN: "14000" # Use a larger port, to avoid colliding with CIRRUS_CACHE_HOST port 12321.
Copy link
Contributor

@hodlinator hodlinator Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing CIRRUS_CACHE_HOST to be below 11000 would be a smaller diff in this file... wait - cirruslabs/cirrus-ci-docs#310 I guess we've been down that lane before.

For reference:

bitcoin/.github/workflows/ci.yml

Line 22 in 286de1e

CIRRUS_CACHE_HOST: http://127.0.0.1:12321/ # When using Cirrus Runners this host can be used by the docker `gha` build cache type.

bitcoin/test/functional/test_framework/util.py

Lines 468 to 471 in 286de1e

# Don't assign p2p, rpc or tor ports lower than this
PORT_MIN = int(os.getenv('TEST_RUNNER_PORT_MIN', default=11000))
# The number of ports to "reserve" for p2p, rpc and tor, each
PORT_RANGE = 5000

@maflcko maflcko deleted the 2602-ci-min-port branch February 27, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@hodlinator hodlinator hodlinator left review comments

@l0rinc l0rinc l0rinc approved these changes

@willcl-ark willcl-ark willcl-ark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

31.0

Development

Successfully merging this pull request may close these issues.

6 participants

@maflcko @DrahtBot @l0rinc @willcl-ark @hodlinator @fanquake