Merged
Conversation
…allet If any other files exist in the directory, we cannot assume the sharable files are exclusively for this wallet. But if they are, this also cleans up other log.* files Github-Pull: bitcoin#34370 Rebased-From: 7475d13
…ils, log the correct wallet name in error message Github-Pull: bitcoin#34370 Rebased-From: 60f5290
…eason Since we no longer delete the wallet directory, there's no need to vacate it The moving only served to risk errors by crossing filesystem boundaries (which fs::rename can't handle) Github-Pull: 34370 Rebased-From: cef01d0
…ating from non-directory While 30.x+ keep backup files in walletdir, 29.x places them in the migrated wallet directory Github-Pull: bitcoin#34370 Rebased-From: 69a6b9b
…et, but not with a shared db environment Github-Pull: bitcoin#34370 Rebased-From: 6517394
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Member
|
Needs a bump to the version in the release-notes. |
dcd13cd to
bfaec08
Compare
Member
Author
Done |
Member
|
Can pull #34671 in here too. |
willcl-ark
approved these changes
Feb 26, 2026
Member
willcl-ark
left a comment
There was a problem hiding this comment.
ACK bfaec08
These all look good to me. Only conflict looks like the MigrateLegacyToDescriptor signature.
Release notes look good too. Can re-review if you add 34671
Fixes bitcoin#33982 Co-authored-by: Purple Ninja <129023353+ToRyVand@users.noreply.github.com> Github-Pull: bitcoin#34671 Rebased-From: faa70ca
bfaec08 to
44e6dda
Compare
Member
Author
|
Backported #34671 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
And the rc2 release process things