depends: Update Qt to version 6.10.2 by hebasto · Pull Request #34578 · bitcoin/bitcoin

hebasto · 2026-02-12T22:40:52Z

This PR updates the qt package in depends to the most recent version 6.10.2.

The update includes many bugfixes that enable dropping some patches.

Additionally, patches for compatibility with GCC 16 have been included.

A commit from #32709 is also included.

DrahtBot · 2026-02-13T04:18:26Z

🚧 At least one of the CI tasks failed.
_{Task macOS-cross to arm64: https://github.com/bitcoin/bitcoin/actions/runs/21967077478/job/63459576763}
_{LLM reason (✨ experimental): Build failed during the bitcoin-qt target compilation (gmake exited with error 1).}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

DrahtBot · 2026-02-13T09:24:59Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#33593 (guix: Use UCRT runtime for Windows release binaries by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto · 2026-02-13T10:40:10Z

Added a commit to update the Windows build notes following @maflcko's suggestion.

theuni · 2026-02-13T17:23:51Z

There are lots of changes here with no explanation. @hebasto Could you please add a bunch of comments?

theuni · 2026-02-13T17:24:28Z

contrib/guix/symbol-check.py

 'GDI32.dll', # graphics device interface
 'IMM32.dll', # input method editor
 'NETAPI32.dll', # network management
+'ntdll.dll', # native system services


I didn't track the exact changes in Windows plugins that link to symbols in ntdll.dll.

theuni · 2026-02-13T17:25:29Z

depends/packages/qt.mk


 $(package)_cmake_opts := -DCMAKE_PREFIX_PATH=$(host_prefix)
 $(package)_cmake_opts += -DQT_FEATURE_cxx20=ON
-$(package)_cmake_opts += -DQT_ENABLE_CXX_EXTENSIONS=OFF


Otherwise, the configuration step logs the following:

-- Configuring done (20.0s) -- Generating done (1.0s) CMake Warning: Manually-specified variables were not used by the project: QT_ENABLE_CXX_EXTENSIONS

Related upstream items:

https://qt-project.atlassian.net/browse/QTBUG-119901

qt/qtbase@30e0434

theuni · 2026-02-13T17:31:09Z

depends/packages/qt.mk

 $(package)_cmake_opts += -DCMAKE_DISABLE_FIND_PACKAGE_WrapZSTD=TRUE
 endif
+ifeq ($(host_os),linux)
+$(package)_cmake_opts += -DINPUT_dbus=runtime


Why? According to cmake/configure-cmake-mapping.md, -dbus-runtime should be mapped to this. Does it not work?

Why? According to cmake/configure-cmake-mapping.md, -dbus-runtime should be mapped to this.

It is not, for some reason. An explanatory comment has been added.

Have we opened an upstream issue?

theuni · 2026-02-13T17:46:11Z

depends/patches/qt/qtbase_xkbcommon_compat.patch

+ endif()
+ qt_add_qmake_lib_dependency(xcb_xinput xcb)
+ if((X11_SUPPORTED) OR QT_FIND_ALL_PACKAGES_ALWAYS)
+-    qt_find_package(XKB 0.9.0 MODULE PROVIDED_TARGETS XKB::XKB MODULE_NAME gui QMAKE_LIB xkbcommon)


What makes it safe to just require the old version? Sure they're not relying on an updated abi?

This was bumped here: qt/qtbase@54132e5

What makes it safe to just require the old version? Sure they're not relying on an updated abi?

The commit you mentioned does not state that this is a prerequisite for other changes.

libxkbcommon 0.9.0 Release Notes list a few changes, including the output of xkb_keymap_get_as_string(). Grepping the Qt source code did not find any calls of this function.

This patch should explain why this is fine to do, rather than explaining why the libxkbcommon package hasn't been updated.

theuni · 2026-02-13T18:13:30Z

depends/patches/qt/static_fixes.patch

@@ -7,70 +7,9 @@ Date:   Sat Oct 4 01:00:25 2025 +0100
    See: https://bugreports.qt.io/browse/QTBUG-86287
    See: https://bugreports.qt.io/browse/QTBUG-137004


I assume one/both of these reports is no longer relevant? Is upstream aware of the remaining issue?

I assume one/both of these reports is no longer relevant?

Right. Removed.

Is upstream aware of the remaining issue?

Not yet.

hebasto · 2026-02-13T20:03:53Z

There are lots of changes here with no explanation. @hebasto Could you please add a bunch of comments?

All changes in qt.mk aim to produce the same (semantically) configure script output as in the master branch.

hebasto · 2026-02-13T20:05:33Z

It seems test_bitcoin-qt.exe is failing in the CI.

fanquake · 2026-02-16T10:19:18Z

Is there are subset of these changes that can be backported to at least 30.x?

fanquake · 2026-02-16T10:21:03Z

depends/patches/qt/cocoa_compat.patch

@@ -0,0 +1,16 @@
+Disable macOS 15 features in QCocoaCursor


Why? How does this effect the binary?

Why?

Otherwise, @available(macOS 15, *) causes a linker error:

<snip> [ 73%] Linking CXX executable ../../bin/bitcoin-qt ld64.lld: error: undefined symbol: __isPlatformVersionAtLeast >>> referenced by /home/hebasto/dev/bitcoin/depends/arm64-apple-darwin/plugins/platforms/libqcocoa.a(qcocoacursor.mm.o):(symbol QCocoaCursor::convertCursor(QCursor*)+0x78) clang++: error: linker command failed with exit code 1 (use -v to see invocation) gmake[2]: *** [src/qt/CMakeFiles/bitcoin-qt.dir/build.make:179: bin/bitcoin-qt] Error 1 gmake[1]: *** [CMakeFiles/Makefile2:2470: src/qt/CMakeFiles/bitcoin-qt.dir/all] Error 2 gmake: *** [Makefile:146: all] Error 2

How does this effect the binary?

The disabled code was introduced in qt/qtbase@4aeb27f. The referenced QTBUG-126240, in turn, refers to the NSCursor API for window resize cursors.

While testing on macOS Tahoe 26.2, I didn't notice any differences in behavior compared to v30.2.

Can you add some information to the patch.

hebasto · 2026-02-16T11:49:24Z

Is there are subset of these changes that can be backported to at least 30.x?

Maybe two @theuni's commits?

fanquake · 2026-02-16T12:52:36Z

Looks like this introduces a dependency on an Xcode installation:

CMake Error at qtbase/cmake/QtPublicAppleHelpers.cmake:943 (message):
  Can't determine Xcode version.  Is Xcode installed? Error details:

  xcrun: error: unable to find utility "xcodebuild", not a developer tool or
  in PATH

Call Stack (most recent call first):
  qtbase/cmake/QtAutoDetectHelpers.cmake:332 (_qt_internal_get_xcode_version_raw)
  qtbase/cmake/QtAutoDetectHelpers.cmake:671 (qt_auto_detect_apple)
  qtbase/cmake/QtAutoDetect.cmake:5 (qt_internal_setup_autodetect)
  qtbase/cmake/QtBaseTopLevelHelpers.cmake:31 (include)
  CMakeLists.txt:13 (qt_internal_top_level_setup_autodetect)

hebasto · 2026-02-16T12:59:17Z

Looks like this introduces a dependency on an Xcode installation:

Are you building on macOS?

fanquake · 2026-02-16T13:00:14Z

Yes that was on a macOS machine.

The `find_package(Qt .. MODULE REQUIRED COMPONENTS ...)` call must treat any missing component as a fatal error.

Backported from: qt/qtbase@7fccc79

Meta-Issue: https://qt-project.atlassian.net/browse/QTBUG-143470 Backports: qt/qtbase@679e8bd qt/qtbase@3312e89 qt/qtbase@05f201a An additional includes fix is needed after the others: qt/qtbase@d68fc6e

Cross-compiling Qt 6.10 for Windows requires GCC 13.1 or newer, which exceeds the currently documented minimum. See https://doc.qt.io/qt-6/windows.html.

hebasto · 2026-02-16T15:58:12Z

Looks like this introduces a dependency on an Xcode installation:

Are you building on macOS?

Should be fixed now.

hebasto · 2026-02-16T20:25:08Z

It seems test_bitcoin-qt.exe is failing in the CI.

Apparently, the issue occurs when building on Debian with GCC 14.0.

The same happens when building on Ubuntu with GCC 13.0.

Everything is fine when building on Fedora with GCC 15.2.

fanquake · 2026-02-17T13:37:43Z

depends/packages/qt.mk

+ifeq ($(build_os),darwin)
+$(package)_cmake_opts += -DQT_NO_XCODE_MIN_VERSION_CHECK=ON
+else
+$(package)_cmake_opts += -DQT_INTERNAL_XCODE_VERSION=$(XCODE_VERSION)


What does this actually effect, and why can't it be disabled everywhere? Xcode isn't available when cross-compiling.

fanquake · 2026-02-17T13:40:26Z

depends/packages/qt.mk

-$(package)_cmake_opts += -DQT_INTERNAL_XCODE_VERSION=$(XCODE_VERSION)
 $(package)_cmake_opts += -DQT_NO_APPLE_SDK_MAX_VERSION_CHECK=ON
+ifeq ($(build_os),darwin)
+$(package)_cmake_opts += -DQT_NO_XCODE_MIN_VERSION_CHECK=ON


Given we have to add patches (https://github.com/bitcoin/bitcoin/pull/34578/changes#diff-672a42bd2b42c415f9edf44da60b1649239f57323844bb042cd595b2f6bc9fc1), just to make these options work properly, should we just patch out the problematic code?

hebasto · 2026-02-17T14:58:19Z

It seems test_bitcoin-qt.exe is failing in the CI.

Apparently, the issue occurs when building on Debian with GCC 14.0.

The same happens when building on Ubuntu with GCC 13.0.

Everything is fine when building on Fedora with GCC 15.2.

The upstream bug report is here: https://qt-project.atlassian.net/browse/QTBUG-144294.

UPDATE: Qt 6.8.3 seems to be working.

hebasto · 2026-02-22T12:14:27Z

It seems test_bitcoin-qt.exe is failing in the CI.

Apparently, the issue occurs when building on Debian with GCC 14.0.
The same happens when building on Ubuntu with GCC 13.0.
Everything is fine when building on Fedora with GCC 15.2.

The upstream bug report is here: https://qt-project.atlassian.net/browse/QTBUG-144294.

UPDATE: Qt 6.8.3 seems to be working.

Closing in favour of #34650.

hebasto added the Build system label Feb 12, 2026

hebasto mentioned this pull request Feb 12, 2026

build: Qt depends build broken with GCC 16 #34569

Closed

DrahtBot added the CI failed label Feb 13, 2026

ircinco-mh mentioned this pull request Feb 13, 2026

. #34579

Closed

hebasto force-pushed the 260212-qt6.10 branch from a851bf7 to 8aa8792 Compare February 13, 2026 09:24

hebasto marked this pull request as ready for review February 13, 2026 09:25

fanquake mentioned this pull request Feb 13, 2026

cmake: Fix FindQt module #32709

Closed

theuni reviewed Feb 13, 2026

View reviewed changes

hebasto force-pushed the 260212-qt6.10 branch from 63ecaa1 to 6affd12 Compare February 13, 2026 19:45

DrahtBot mentioned this pull request Feb 15, 2026

guix: Use UCRT runtime for Windows release binaries #33593

Open

fanquake reviewed Feb 16, 2026

View reviewed changes

cmake: Fix FindQt module

86b5163

The `find_package(Qt .. MODULE REQUIRED COMPONENTS ...)` call must treat any missing component as a fatal error.

hebasto force-pushed the 260212-qt6.10 branch from 6affd12 to ef29945 Compare February 16, 2026 15:17

hebasto and others added 4 commits February 16, 2026 15:45

depends: Update Qt to 6.10.2

8a3d3dc

qt: add patch to fix build with gcc16

116cfd3

Backported from: qt/qtbase@7fccc79

qt: add patches to fix SFINAE errors/warnings with gcc16

1a469be

Meta-Issue: https://qt-project.atlassian.net/browse/QTBUG-143470 Backports: qt/qtbase@679e8bd qt/qtbase@3312e89 qt/qtbase@05f201a An additional includes fix is needed after the others: qt/qtbase@d68fc6e

doc: Update Windows build notes

f857d92

Cross-compiling Qt 6.10 for Windows requires GCC 13.1 or newer, which exceeds the currently documented minimum. See https://doc.qt.io/qt-6/windows.html.

hebasto force-pushed the 260212-qt6.10 branch from ef29945 to f857d92 Compare February 16, 2026 15:49

fanquake reviewed Feb 17, 2026

View reviewed changes

hebasto closed this Feb 22, 2026

hebasto mentioned this pull request Feb 24, 2026

depends: Update Qt to version 6.8.3 #34650

Merged

		@@ -7,70 +7,9 @@ Date: Sat Oct 4 01:00:25 2025 +0100
		See: https://bugreports.qt.io/browse/QTBUG-86287
		See: https://bugreports.qt.io/browse/QTBUG-137004

Conversation

hebasto commented Feb 12, 2026

Uh oh!

DrahtBot commented Feb 13, 2026

Uh oh!

DrahtBot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

hebasto commented Feb 13, 2026

Uh oh!

theuni commented Feb 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto commented Feb 13, 2026

Uh oh!

hebasto commented Feb 13, 2026

Uh oh!

fanquake commented Feb 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto commented Feb 16, 2026

Uh oh!

fanquake commented Feb 16, 2026

Uh oh!

hebasto commented Feb 16, 2026

Uh oh!

fanquake commented Feb 16, 2026

Uh oh!

hebasto commented Feb 16, 2026

Uh oh!

hebasto commented Feb 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

DrahtBot commented Feb 13, 2026 •

edited

Loading

hebasto Feb 13, 2026 •

edited

Loading

hebasto commented Feb 17, 2026 •

edited

Loading