Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
029a399 to
28b6216
Compare
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
maflcko
left a comment
There was a problem hiding this comment.
nice, this should catch the compile issues. Can't comment much on the build system changes, though
| @@ -1,31 +1,39 @@ | |||
| FREEBSD_VERSION=15.0 | |||
There was a problem hiding this comment.
will this hard-code the version for everyone?
28b6216 to
1aad432
Compare
You can drop this from the OP, given #34093 (comment) |
This refers to the alternative approach, which was using unpinned third-party deps, so I think the pull request description is correct. |
4fc13d7 to
964fa34
Compare
6be706d to
2f969ba
Compare
|
Switched to FreeBSD |
2f969ba to
c35cd4a
Compare
Alternative to #33562, which was adding a native FreeBSD job; however that had issues with permissions/caching, as well as potential determinism issues. This adds a FreeBSD cross job using Linux and Clang.
Would close #33438. The same changes here could also be used to produce FreeBSD binaries out of Guix.