Skip to content

[29.x] backports + final changes for 29.3rc2#34450

Merged
fanquake merged 4 commits intobitcoin:29.xfrom
sedited:29.3rc2-finalize
Jan 30, 2026
Merged

[29.x] backports + final changes for 29.3rc2#34450
fanquake merged 4 commits intobitcoin:29.xfrom
sedited:29.3rc2-finalize

Conversation

@sedited
Copy link
Contributor

@sedited sedited commented Jan 29, 2026

Backport:

And finalize 29.3rc2.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 29, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@fanquake fanquake added this to the 29.3 milestone Jan 29, 2026
@sedited sedited changed the title [29.x] backports + final changes for 29.3 [29.x] backports + final changes for 29.3rc2 Jan 29, 2026
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 76d6fa9, I have reviewed the code and it looks OK.

@achow101
Copy link
Member

Should add #34370 to the release notes, although I'd give it a more descriptive title, maybe "wallet: Additional cleanups for migration, and fixes for createfromdump with BDB"

@sedited
Copy link
Contributor Author

sedited commented Jan 30, 2026

Updated 76d6fa9 -> 2b2c4da (29.3rc2-finalize_0 -> 29.3rc2-finalize_1, compare)

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 2b2c4da.

@fanquake fanquake merged commit 8de2549 into bitcoin:29.x Jan 30, 2026
19 checks passed
@glozow glozow mentioned this pull request Jan 30, 2026
7 tasks
@@ -1,7 +1,7 @@
.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3.
.TH BITCOIN-CLI "1" "January 2026" "bitcoin-cli v29.3.0rc1" "User Commands"
.TH BITCOIN-CLI "1" "January 2026" "bitcoin-cli v29.3.0rc2" "User Commands"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jan 1st?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 is the section number, see man man-pages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1 isn't a date, it's the section number of the manpage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants