Skip to content

[29.x] Backport CI changes#34446

Merged
fanquake merged 3 commits intobitcoin:29.xfrom
fanquake:29_x_ci_changes
Jan 29, 2026
Merged

[29.x] Backport CI changes#34446
fanquake merged 3 commits intobitcoin:29.xfrom
fanquake:29_x_ci_changes

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 29, 2026 •
edited
Loading

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 29, 2026 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK willcl-ark, sedited

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@fanquake
Copy link
Member Author

fanquake commented Jan 29, 2026

Error The action ilammy/msvc-dev-cmd@v1 is not allowed in bitcoin/bitcoin

Failed as expected. Will add the backport.

m3dwards and others added 2 commits January 29, 2026 14:30
@m3dwards @fanquake
ci: remove 3rd party js from windows dll gha job
6aec095 
We can use vswhere.exe directly to create a vs developer
prompt and so can remove this third party dependency.

Co-authored-by: David Gumberg <davidzgumberg@gmail.com>

Github-Pull: bitcoin#32513
Rebased-From: 7ae0497
@fanquake
doc: update release notes for v29.x
3835e16
@fanquake fanquake mentioned this pull request Jan 29, 2026
Merged
@willcl-ark
Copy link
Member

willcl-ark commented Jan 29, 2026

Can you confirm whether #32513 is supposed to be only partially backported here?

Missing commit from original PR #32513:
e1a1b14c935 ci: use a more generic way of finding mt.exe

Missing commit from original PR #32513:
156927903d6 ci: Check windows manifests for all executables

@fanquake
Copy link
Member Author

fanquake commented Jan 29, 2026

Can you confirm whether #32513 is supposed to be only partially backported here?

Yea.

@willcl-ark
Copy link
Member

willcl-ark commented Jan 29, 2026

Yea.

OK. LGTM at the moment then :)

@fanquake fanquake marked this pull request as ready for review January 29, 2026 14:49
willcl-ark
willcl-ark approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@willcl-ark willcl-ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3835e16

@fanquake fanquake requested a review from marcofleon January 29, 2026 15:48
sedited
sedited approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3835e16

@fanquake fanquake merged commit 74bf92e into bitcoin:29.x Jan 29, 2026
18 of 19 checks passed
@fanquake fanquake deleted the 29_x_ci_changes branch January 29, 2026 16:23
@fanquake fanquake added this to the 29.3 milestone Jan 29, 2026
@fanquake fanquake mentioned this pull request Feb 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sedited sedited sedited approved these changes

@marcofleon marcofleon Awaiting requested review from marcofleon

+1 more reviewer

@willcl-ark willcl-ark willcl-ark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backport

Projects

None yet

Milestone

29.3

Development

Successfully merging this pull request may close these issues.

6 participants

@fanquake @DrahtBot @willcl-ark @sedited @pgoslatara @m3dwards