The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34392.

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

ACK facc35a

i tested with --ignore-self-check-warnings

before test exists early

Temporary test directory at /tmp/test_runner_₿_🏃_20260125_092010
WARNING! The following scripts are not being run: ['a.py']. Check the test lists in test_runner.py.

after

./build/test/functional/test_runner.py wallet_disable --ignore-self-check-warnings
Temporary test directory at /tmp/test_runner_₿_🏃_20260125_092409
WARNING! The following scripts are not being run: ['a.py']. Check the test lists in test_runner.py, or use --ignore-self-check-warnings to ignore the error.
Remaining jobs: [wallet_disable.py]
1/1 - wallet_disable.py passed, Duration: 0 s

TEST              | STATUS    | DURATION

wallet_disable.py | ✓ Passed  | 0 s

ALL               | ✓ Passed  | 0 s (accumulated) 
Runtime: 0 s

Put into draft for now. I maintain my point (#34279 (comment)) that it should be trivial and beneficial to just add the test to the list. It is a one-line change and a call to git commit. It shouldn't take more than a few seconds and only comes with upsides?

Put into draft for now. I maintain my point (#34279 (comment)) that it should be trivial and beneficial to just add the test to the list. It is a one-line change and a call to git commit. It shouldn't take more than a few seconds and only comes with upsides?

i feel like this helps devs who keep temporary local tests in their worktree and still be able to run the full suite withot having to edit test_runner.py or delete their working local files since default fail behavior remains and ci unchanged

i feel like this helps devs who keep temporary local tests

Fair enough. It helps for temporary tests that are meant to be thrown away soon. However, for any test meant to stay around longer than a month, properly integrating it in the list and into a git commit (and local git history) just seems better to me.

However, for any test meant to stay around longer than a month, properly integrating it in the list and into a git commit (and local git history) just seems better to me.

I'm also not sure why the functional tests should get a different treatment than say a unit test that needs to be integrated. Also seems easy enough to add the test to the runner on the fly with a simple out of tree patch.

Ok, closing for now. I don't care about this in any way, so I think whoever is bothered by this should open the pull request with the commit.