wallet: re-activate "AmountWithFeeExceedsBalance" error #34299
+74
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is not needed for the remaining commits but good to fix and came up in bitcoin#25269 review. Co-authored-by: furszy <matiasfurszyfer@protonmail.com>
using total_amount variable to store either the actual total amount or effective total amount based on whether SFFO is enabled is confusing. keep this SFFO-based functionality in a separate function GetTotal() and store both total_amount and effective total amount separately. without this when SFFO is not there, available_balance in the next commit would yield inconsistent result: - effective amount of preset_inputs summed with - total amount of available_coins.
…error This was previously implemented at the GUI level but we never hit that code path. Co-authored-by: furszy <matiasfurszyfer@protonmail.com>
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34299. ReviewsSee the guideline for information on the review process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picks up #25269.
AmountWithFeeExceedsBalanceerror insideWalletModel::prepareTransactionis never thrown and remains an unused code path. This is becausecreateTransactiondoes not retrieve the fee when the process fails. The fee return arg is set only at the end of the process, when the transaction is successfully created. Therefore, if the transaction creation fails, the fee is not available insideWalletModel::prepareTransactionto trigger theAmountWithFeeExceedsBalanceerror.This PR re-implements the feature inside
CreateTransactionInternaland adds test coverage for it.the unreachable code path is removed in bitcoin-core/gui#807 which requires this PR.