Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jan 14, 2026

The compiler option -fdebug-prefix-map is unconditionally set by the build system. This is problematic for many reasons:

Fix all issues by temporarily removing it.

Though, the option is kept for the guix build, so that no change in behavior is observed for the release binaries.

Fixes #31957
Fixes #31204

The option can be added back in the future, if there is any need to. Though, adding it back should ideally work out of the box, or at least provide easy workarounds for all commonly used tooling.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 14, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34281.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@maflcko
Copy link
Member Author

maflcko commented Jan 14, 2026

I've also tested against #30799 via:

./bld-c/bin/bitcoind -printtoconsole -logsourcelocations -regtest | grep 'Bitcoin Core version'
2026-01-14T15:01:26Z [init/common.cpp:153] [LogPackageVersion] Bitcoin Core version v30.99.0-fa37928536e0-dirty (release build)

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 9d2b8fd
(master)
commit 618f382
(pull/34281/merge)
*-aarch64-linux-gnu-debug.tar.gz b54752db32c2706e... 3f3f3d8c91f16314...
*-aarch64-linux-gnu.tar.gz 7387717e93633171... e73ec99d962056f1...
*-arm-linux-gnueabihf-debug.tar.gz 3d10cef692d6a3b6... e3560f167e7832a5...
*-arm-linux-gnueabihf.tar.gz 2792a8fe85618eaf... dd1d822ecc1896e1...
*-powerpc64-linux-gnu-debug.tar.gz 2e16367d642a352f... 89063687ff18dea6...
*-powerpc64-linux-gnu.tar.gz 874718a62b0031b3... 97e93950bb714fa6...
*-riscv64-linux-gnu-debug.tar.gz 2c15225fd864f492... 2e59aadeab641038...
*-riscv64-linux-gnu.tar.gz e0fd8eb5f9d8956f... c952e7228c28b387...
*-x86_64-linux-gnu-debug.tar.gz d0fafcff098c5c31... 816a772cefce72e0...
*-x86_64-linux-gnu.tar.gz 0b3f2365df75910f... e816a916290c562d...
*.tar.gz 8cfd0b29aa4dadf3... 18adea8ba1188b7e...
SHA256SUMS.part 341ba0fbf217de81... 9a034a9b6d197395...
guix_build.log 6354adc2c35caf3a... cbe028d6727a8c10...
guix_build.log.diff cef15d77dd34ffe3...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

callgrind_annotate broken after cmake migration? Source code mapping for debugger has changed since cmake

2 participants