Remove empty caption from user interface (noui, gui) #34276
Conversation
This is redundant and inconsistent, because call-sites are expected to add the semicolon, which they all do.
This refactor makes the code easier to read and maintain.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34276. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Does this PR introduce any visual changes in the GUI? |
No, see the pull request description. |
There is only one call-site, which provided an empty caption. Note that noui_ThreadSafeQuestionRedirect is test-only and currently entrirely unused, so the logging format string change is not a behavior change. This refactor does not change any behavior.
The caption was empty for all call-sites, so this refactor does not change any behavior. Note that noui_ThreadSafeMessageBoxRedirect is test-only, so no end-user behavior is changed here.
This refactor does not change any behavior.
The only behavior change is in noui_ThreadSafeQuestion, which can not detect a style and will log a strCaption=": ". Fix this by removing it.
fa9b792 to
fad7bd9
Compare
|
To clarify that everything is a refactor, except for the one-line bugfix, I've extracted it as the last commit. You can also use this to check that the GUI pop-up looks identical before and after: |
|
Concept ACK. |
Currently, the user interface (noui, gui) has a caption for each message. However, the caption has many issues:
nouiwill ignore the caption and set the logging prefix (error, warning, info) based on thestyle.Fix all issues by removing it.