[29.x] backports + final changes for 29.3 #34268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#33475 Rebased-From: b807dfc
Github-Pull: bitcoin#33723 Rebased-From: b0c7067
Github-Pull: bitcoin#34227 Rebased-From: 194114d
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34268. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
glozow
commented
Jan 12, 2026
689fccc to
00a8f41
Compare
Member
Author
This was referenced Jan 13, 2026
fanquake
reviewed
Jan 13, 2026
00a8f41 to
b7ae655
Compare
b7ae655 to
55fd7b9
Compare
If something is imported into the wallet, it can change the 'from me' status of a transaction. This status is only visible through gettransaction's "fee" field which is only shown for transactions that are 'from me'. Github-Pull: bitcoin#33268 Rebased-From: e76c2f7
Instead of checking whether the total amount of inputs known by the wallet is greater than 0, we should be checking for whether the input is known by the wallet. This enables us to determine whether a transaction spends an of output with an amount of 0, which is necessary for marking 0-value dust outputs as spent. Github-Pull: bitcoin#33268 Rebased-From: 39a7dbd
Github-Pull: bitcoin#33268 Rebased-From: c40dc82
55fd7b9 to
794f666
Compare
794f666 to
b834447
Compare
Member
|
ACK b834447 |
janb84
reviewed
Jan 14, 2026
Member
Author
That's fine, and probably would have been better to leave the comment up. Context: #33623 isn't a backport; it was directly merged to 29.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
osslsigncodetests #34227addPackageTxsunsigned integer overflow #33475And final changes for 29.3rc1