test: Improve code coverage for pubkey checks#34058
Closed
billymcbip wants to merge 1 commit intobitcoin:masterfrom
Closed
test: Improve code coverage for pubkey checks#34058billymcbip wants to merge 1 commit intobitcoin:masterfrom
billymcbip wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34058. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
rkrux
reviewed
Dec 15, 2025
Contributor
rkrux
left a comment
There was a problem hiding this comment.
Code review a00332f
Few conditions in the mentioned functions indeed don't seem to be covered in the tests.
The coverage report seems to be not available in corecheck for some reason: https://corecheck.dev/bitcoin/bitcoin/pulls/34058
Coverage report is currently being generated, please come back later
Contributor
|
tACK a00332f |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover these branches in
IsCompressedOrUncompressedPubKeyandIsCompressedPubKey:Non-canonical public key: invalid length for uncompressed keyNon-canonical public key: invalid length for compressed keyNon-canonical public key: invalid prefix for compressed keySee the missed branches here: https://maflcko.github.io/b-c-cov/total.coverage/src/script/interpreter.cpp.gcov.html
script_testssucceed on my end.