[30.x] Backports & 30.1rc1 #33997
Merged
[30.x] Backports & 30.1rc1 #33997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only include what we really need. Skip 100s of mb of manpages, swiftmodules, modulemaps. Note that System/Library is only needed for the Qt build. Github-Pull: bitcoin#32009 Rebased-From: a33d034
Starting with Python 3.11, Pythons gzip might delegate to zlib. Depending on the OS, i.e Ubuntu vs Fedora, the underlying zlib implementation might differ, resulting in different output. For now, or until a better solution exists, disable compression. This results in the SDK increasing in size to ~157mb. Which is not unreasonable, to regain determinism (and would be significantly worse without the previous commit). See: https://docs.python.org/3/library/gzip.html#gzip.compress Co-authored-by: stickies-v <stickies-v@protonmail.com> Github-Pull: bitcoin#32009 Rebased-From: c1213a3
This puts it in scope for the Python linters. Github-Pull: bitcoin#32009 Rebased-From: 3e01b5d
0972f55 from bitcoin#33229 broke manpage generation, because the assumption that the last word in the line containing the version number, was the version number, no-longer holds for some binaries. i.e bitcoind. Github-Pull: bitcoin#33996 Rebased-From: e9536fa
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33997. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
This was referenced Dec 3, 2025
49baaca to
62af018
Compare
…cestors Github-Pull: bitcoin#33528 Rebased-From: e753fad
Github-Pull: bitcoin#33528 Rebased-From: dcd42d6
Github-Pull: bitcoin#33723 Rebased-From: b0c7067
hebasto
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
Prior
30.xbackports in #33609.