init: Improve -asmap option behavior and documentation #33632
Conversation
Otherwise -asmap=1, for example, would be interpreted as a path "1".
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33632. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
0948cd1 to
9d33b6d
Compare
|
I think this is ok to close, since my suggestion about improving the default behavior #33631 (comment) as a better alternative to that PR also seems like it could be a better alternative to this PR. I do think the approach in the PR is reasonable, though. It could also be implemented by calling |
Note: There is an alternative change that turns
-asmapinto a bool option and adds a-asmapfileoption: #33631 Please indicate with your conceptual review which option you prefer, thanks!This changes the behavior of the
GetPathArgfunction to better work with the behavior of-asmap. When a path arg is given "1" (for example -asmap=1), this would currently be interpreted as a path but should be interpreted as using the arg without a parameter which activates the fallback. There is no explicit test added here because this is tested implicitly in the tests added in #28792.Also improves the documentation of the
-asmapdefault behavior.See #33386 for further discussion. Closes #33386