contrib: remove deprecated --deep signing from macdeployqtplus#33592
Open
amishhaa wants to merge 1 commit intobitcoin:masterfrom
Open
contrib: remove deprecated --deep signing from macdeployqtplus#33592amishhaa wants to merge 1 commit intobitcoin:masterfrom
amishhaa wants to merge 1 commit intobitcoin:masterfrom
Conversation
Removed the deprecated --deep flag from codesign in macdeployqtplus and replaced it with an explicit recrusive signing process for all binaries, frameworks, and plugins.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33592. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsNo conflicts as of last run. |
Member
|
Concept ACK. |
Contributor
|
Could somebody with a Mac try this out? It's been open for a while, but I'm having a hard time judging its correctness. |
hebasto
reviewed
Mar 5, 2026
Comment on lines
+521
to
+534
| plugins_path = os.path.join(contents_path, "PlugIns") | ||
| if os.path.exists(plugins_path): | ||
| for root, _, files in os.walk(plugins_path): | ||
| for f in files: | ||
| full_path = os.path.join(root, f) | ||
| if is_macho_executable(full_path): | ||
| sign_item(full_path, identity) | ||
|
|
||
| macos_path = os.path.join(contents_path, "MacOS") | ||
| if os.path.exists(macos_path): | ||
| for f in os.listdir(macos_path): | ||
| full_path = os.path.join(macos_path, f) | ||
| if os.path.isfile(full_path) and is_macho_executable(full_path): | ||
| sign_item(full_path, identity) |
Member
There was a problem hiding this comment.
My tests also pass without this snippet for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the deprecated
--deepflag from codesign in macdeployqtplus and replaced it with an explicit recursive signing process for all binaries, frameworks, and plugins.Fixes #32486