Conversation
Remove it in feerate. Fix it in the other places. Github-Pull: bitcoin#33236 Rebased-From: 966666d
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33271. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
willcl-ark
left a comment
There was a problem hiding this comment.
ACK 084c95a
This all looks correct to me
stickies-v
left a comment
There was a problem hiding this comment.
ACK 084c95a
Backport commits aren't clean, but the changes lgtm:
- 6448ebb backported from 966666d: merge-conflict because d3b8a54 changed the
CFeeRatedocstring - 99ab2e7 backported from 509ffea: merge-conflict because of the added
ninja-buildfrom 30dd1f1
Verified that all backported PRs are listed in release notes (unless they are missing the Github-Pull comment) (except #33011 and #33211 but those are follow-ups to #32604, which is mentioned).
Verified that I have identical manpages.
There was a problem hiding this comment.
nit: it seems we don't have consistent manner of labeling GUI PRs, with a quick grep showing existing approaches like:
#<gui-pr>gui#<gui-pr>#gui<gui-pr>bitcoin-core/gui#<gui-pr>
No strong view, but perhaps using gui#<gui-pr> here would make sense, since it probably confuses people not familiar with our dual-repo setup:
### Gui
- gui#864 Crash fix, disconnect numBlocksChanged() signal during shutdown
- gui#868 Replace stray tfm::format to cerr with qWarning
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Backports:
Since
rc2, #33212 was also backported in #33251.