Skip to content

mini miner: enable Linearize return package feerates #33216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ismaelsadeeq wants to merge 1 commit into from
Closed

mini miner: enable Linearize return package feerates #33216

ismaelsadeeq wants to merge 1 commit into from

Conversation

@ismaelsadeeq
Copy link
Member

@ismaelsadeeq ismaelsadeeq commented Aug 19, 2025 •
edited
Loading

This PR adds supports for mini miner to return the package fee rates of the linearized transactions

The first step for #30079

It is motivated by #30079 (comment)

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 19, 2025 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33216.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK murchandamus

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30079 (Fee Estimation: Ignore all transactions that are CPFP'd by ismaelsadeeq)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@ismaelsadeeq ismaelsadeeq mentioned this pull request Aug 19, 2025
Closed
optout21
optout21 reviewed Sep 2, 2025
View reviewed changes
optout21
optout21 reviewed Sep 2, 2025
View reviewed changes
@ismaelsadeeq @willcl-ark
mini miner: enable Linearize return package feerates
c24b183 
Co-authored-by: willcl-ark <will@256k1.dev>
@ismaelsadeeq ismaelsadeeq force-pushed the 08-2025-mini-miner-return-packages branch from ed6752c to c24b183 Compare September 2, 2025 19:49
@optout21
Copy link
Contributor

optout21 commented Sep 3, 2025

This PR only extends the return data with the package fee rate, but it does not use the new data. Is a follow-up PR available (as draft) where the new data is used?

@ismaelsadeeq
Copy link
Member Author

ismaelsadeeq commented Sep 4, 2025

Yes it is used in #30079

@murchandamus
Copy link
Contributor

murchandamus commented Nov 3, 2025

Concept ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@optout21 optout21 optout21 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Utils/log/libs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ismaelsadeeq @DrahtBot @optout21 @murchandamus @glozow