[29.x] qt: 29.1 translations update #32352

hebasto · 2025-04-25T14:21:58Z

This PR fetches the recent translation updates from Transifex.

Closes #32295.

Notes for reviewers:

"fr_CM" and "fr_LU" have been dropped as part of phasing out of territory-specific translations.
The translations for the following languages, which appear to be the result of a mistake or an act of vandalism, have been discarded (also see qt: 29.0 translations update #32004):
- Czech (cs)
- Danish (da)
- Dutch (nl)
- Vietnamese (vi)
Update for Silesian (szl) has been discarded as malicious.

DrahtBot · 2025-04-25T14:22:01Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32352.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	laanwj

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto · 2025-04-25T14:26:56Z

Closes #32295.

However, the Polish (pl) translation still have a couple of issues:

String 160: Mismatch between 'S&how' and '%Wyświetl'
String 452: Mismatch between 'Transaction broadcast successfully! Transaction ID: %1' and 'transakcja'

hebasto · 2025-04-25T14:53:49Z

Closes #32295.

However, the Polish (pl) translation still have a couple of issues:
1. String 160: Mismatch between 'S&how' and '%Wyświetl'

2. String 452: Mismatch between 'Transaction broadcast successfully! Transaction ID: %1' and 'transakcja'

Friendly ping @jesterhodl :)

jesterhodl · 2025-04-25T14:57:53Z

Transaction broadcast successfully

Both fixed in Transifex.

hebasto · 2025-04-25T15:19:59Z

Transaction broadcast successfully

Both fixed in Transifex.

Thanks! Updated and undrafted.

jesterhodl · 2025-04-25T17:19:21Z

So I rerun the script and found some more issues and updated Transifex.
v29 is not translated 100% yet from what I see, but at least the worst offenders: spam, typos, gross errors should be fixed now.

hebasto · 2025-04-25T17:57:16Z

So I rerun the script and found some more issues and updated Transifex. v29 is not translated 100% yet from what I see, but at least the worst offenders: spam, typos, gross errors should be fixed now.

Thank you! Updated.

maflcko · 2025-04-27T08:08:58Z

The erroneous format specs still remain: #32295 (comment)

jesterhodl · 2025-04-27T12:44:26Z

The erroneous format specs still remain: #32295 (comment)

Ok, for Polish there was one. I just corrected it.
I'm happy to correct other languages for this sort of issue, but I'm only granted access to Polish team in Transifex.
If someone grants me temporary access I can fix others and go back to being just Polish Team.

jesterhodl · 2025-04-27T15:44:03Z

check_translations shouldn't complain for any polish labels as of now. I ran it.
Transifex is updated.

maflcko · 2025-04-27T16:00:25Z

check_translations shouldn't complain for any polish labels as of now. I ran it.

Thanks. Just for reference, the script doesn't need to report no complaints. Sometimes it complains about perfectly fine translations. Also, it may not even be deterministic if called several times with a cleared cache.

jesterhodl · 2025-04-27T16:03:01Z

check_translations shouldn't complain for any polish labels as of now. I ran it.

Thanks. Just for reference, the script doesn't need to report no complaints. Sometimes it complains about perfectly fine translations. Also, it may not even be deterministic if called several times with a cleared cache.

OK. By the way I noticed it. It complained A should be B, and then B should be A. Neither form would make it happy. I opted for something else.

hebasto · 2025-05-02T10:50:03Z

Fetched the updated Polish (pl) translation. Thanks to @jesterhodl !

@maflcko's comment has also been addressed.

I believe that any further translation improvements should be made through communication with the language coordinators, which I'm currently trying to arrange.

jesterhodl · 2025-05-02T10:56:46Z

Going forward:

who do I contact if there's an issue with source labels?
do I have to do anything when I just maintain new or updated labels? eg. when I align wording across the app

hebasto · 2025-05-02T10:57:01Z

cc @stickies-v @pablomartin4btc @johnny9 as regular reviewers of similar previous PRs.

cc @fanquake as the 29.1 release manager.

hebasto · 2025-05-02T10:57:59Z

Going forward:

who do I contact if there's an issue with source labels?

Feel free to ping me.

do I have to do anything when I just maintain new or updated labels? eg. when I align wording across the app

Mind clarifying please?

jesterhodl · 2025-05-02T12:08:39Z

do I have to do anything when I just maintain new or updated labels? eg. when I align wording across the app

Mind clarifying please?

Sure. I translate lots of apps on Transifex, Weblate, etc.
I routinely revisit to check for new things to update or correct existing translations based on my experience or feedback.
So I update the transifex translations.

When I do this, is it sufficient and github pulls the .ts files automatically, or would it be wise to ping someone?

hebasto · 2025-05-02T13:26:20Z

do I have to do anything when I just maintain new or updated labels? eg. when I align wording across the app

Mind clarifying please?

Sure. I translate lots of apps on Transifex, Weblate, etc. I routinely revisit to check for new things to update or correct existing translations based on my experience or feedback. So I update the transifex translations.

When I do this, is it sufficient and github pulls the .ts files automatically, or would it be wise to ping someone?

Yes, that is sufficient, provided no one else has modified your translations. In that case, marking translations as reviewed might help.

UPD. However, not "automatically", rather in pull requests like this one.

laanwj · 2025-05-06T14:13:01Z

src/qt/locale/bitcoin_es.ts

    <message>
        <source>Warning: If you encrypt your wallet and lose your passphrase, you will &lt;b&gt;LOSE ALL OF YOUR BITCOINS&lt;/b&gt;!</source>
-        <translation type="unfinished">Atención: Si cifras el monedero y pierdes la frase de contraseña, &lt;b&gt;¡PERDERÁS TODOS TUS BITCOINS&lt;/b&gt;!</translation>
+        <translation type="unfinished">Atención: Si cifras el monedero y pierdes la frase de contraseña, &lt;b&gt;¡PERDERÁS TODOS TUS BITCOIN&lt;/b&gt;!</translation>


First thought this change was a bit strange, but "lose all your bitcoin" singular might make more sense even in English?

laanwj · 2025-05-06T14:15:23Z

src/qt/locale/bitcoin_bg.ts

        <source>Creating Wallet &lt;b&gt;%1&lt;/b&gt;…</source>
        <extracomment>Descriptive text of the create wallet progress window which indicates to the user which wallet is currently being created.</extracomment>
-        <translation type="unfinished">Създаване на уолет 1 1%1 1</translation>
+        <translation type="unfinished">Създаване на уолет &lt;b&gt;%1&lt;/b&gt;…</translation>


This update looks correct, but we should really avoid having format codes in the translations, %n substitutes combined with HTML make it doubly confusing for translators.

This comes from:

bitcoin/src/qt/walletcontroller.cpp

Lines 251 to 253 in f490f55

/*: Descriptive text of the create wallet progress window which indicates

to the user which wallet is currently being created. */

tr("Creating Wallet %1…").arg(m_create_wallet_dialog->walletName().toHtmlEscaped()));

laanwj · 2025-05-06T14:21:14Z

src/qt/locale/bitcoin_es.ts

        <translation type="unfinished">Cerrar monedero</translation>
    </message>
    <message>
        <source>Are you sure you wish to close the wallet &lt;i&gt;%1&lt;/i&gt;?</source>


Another translation with HTML in it.

This comes from:

bitcoin/src/qt/walletcontroller.cpp

Line 94 in f490f55

box.setText(tr("Are you sure you wish to close the wallet %1?").arg(GUIUtil::HtmlEscape(wallet_model->getDisplayName())));

Right! At some point we should refactor entries like this to

box.setText(tr("Are you sure you wish to close the wallet %1?").arg("" + GUIUtil::HtmlEscape(wallet_model->getDisplayName()) + ""));

But not for this version ofc.

laanwj · 2025-05-06T14:31:28Z

src/qt/locale/bitcoin_es.ts

    <message>
        <source>Last received block was generated %1 ago.</source>
-        <translation type="unfinished">El último bloque recibido fue generado hace %1 horas.</translation>
+        <translation type="unfinished">El último bloque recibido fue generado hace %1 .</translation>


Looks correct "horas" means hours, and this isn't about hours. It is introducing a redundant space before the dot here.

laanwj

ACK fc60337

i looked over the changes and did some spot checks and found nothing that looks malicious or appears out of the ordinary.

laanwj · 2025-05-06T15:48:20Z

src/qt/locale/bitcoin_th.ts

-        <extracomment>Name of the menu item that restores wallet from a backup file.</extracomment>
-        <translation type="unfinished">กู้คืนวอลเล็ต…</translation>
+        <source>Last Send</source>
+        <translation type="unfinished">ส่งสุดท้าย (Song Soot Thai)</translation>


These parenthesized additions in non-Thai letters like (Song Soot Thai) here are a bit strange (Google translate can't make anything from it, and Google itself only has a match from reddit). Might want to ask someone who knows the language.

hebasto added this to the 29.1 milestone Apr 25, 2025

DrahtBot added the Backport label Apr 25, 2025

hebasto mentioned this pull request Apr 25, 2025

gui: translation spam? #32295

Closed

hebasto force-pushed the 250426-29.x-translations branch from 7a7757e to 4a6fddb Compare April 25, 2025 15:19

hebasto marked this pull request as ready for review April 25, 2025 15:20

hebasto force-pushed the 250426-29.x-translations branch from 4a6fddb to eb78022 Compare April 25, 2025 17:56

qt: 29.1 translations update

fc60337

hebasto force-pushed the 250426-29.x-translations branch from eb78022 to fc60337 Compare May 2, 2025 10:43

laanwj reviewed May 6, 2025

View reviewed changes

laanwj approved these changes May 6, 2025

View reviewed changes

laanwj reviewed May 6, 2025

View reviewed changes

fanquake merged commit 3fad438 into bitcoin:29.x May 6, 2025
17 of 18 checks passed

hebasto deleted the 250426-29.x-translations branch May 6, 2025 20:34

maflcko mentioned this pull request Jun 18, 2025

check_translations: check for spaces maflcko/DrahtBot#49

Closed

	/*: Descriptive text of the create wallet progress window which indicates
	to the user which wallet is currently being created. */
	tr("Creating Wallet <b>%1</b>…").arg(m_create_wallet_dialog->walletName().toHtmlEscaped()));

[29.x] qt: 29.1 translations update #32352

[29.x] qt: 29.1 translations update #32352

Uh oh!

Conversation

hebasto commented Apr 25, 2025

Uh oh!

DrahtBot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Uh oh!

hebasto commented Apr 25, 2025

Uh oh!

hebasto commented Apr 25, 2025

Uh oh!

jesterhodl commented Apr 25, 2025

Uh oh!

hebasto commented Apr 25, 2025

Uh oh!

jesterhodl commented Apr 25, 2025

Uh oh!

hebasto commented Apr 25, 2025

Uh oh!

maflcko commented Apr 27, 2025

Uh oh!

jesterhodl commented Apr 27, 2025

Uh oh!

jesterhodl commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Apr 27, 2025

Uh oh!

jesterhodl commented Apr 27, 2025

Uh oh!

hebasto commented May 2, 2025

Uh oh!

jesterhodl commented May 2, 2025

Uh oh!

hebasto commented May 2, 2025

Uh oh!

hebasto commented May 2, 2025

Uh oh!

jesterhodl commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj May 6, 2025

Choose a reason for hiding this comment

Uh oh!

laanwj May 6, 2025

Choose a reason for hiding this comment

Uh oh!

hebasto May 6, 2025

Choose a reason for hiding this comment

Uh oh!

laanwj May 6, 2025

Choose a reason for hiding this comment

Uh oh!

hebasto May 6, 2025

Choose a reason for hiding this comment

Uh oh!

laanwj May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj May 6, 2025

Choose a reason for hiding this comment

Uh oh!

laanwj left a comment

Choose a reason for hiding this comment

Uh oh!

laanwj May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

DrahtBot commented Apr 25, 2025 •

edited

Loading

jesterhodl commented Apr 27, 2025 •

edited

Loading

jesterhodl commented May 2, 2025 •

edited

Loading

hebasto commented May 2, 2025 •

edited

Loading

laanwj May 6, 2025 •

edited

Loading

laanwj May 6, 2025 •

edited

Loading