test: Treat executable paths in tests consistently #32324
Conversation
When using multi-config CMake generators, executable paths include per-config subdirectories, which require special handling in tests. Using dedicated environment variables to specify executable paths works well in such scenarios. However, the `util_test_runner` test sets these variables for the `util/test_runner.py` script unconditionally, which diverges from the approach used when running `functional/test_runner.py`. This change makes the usage of the aforementioned environment variables uniform.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32324. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Seems fine. An alternative could be to remove |
The question is how to choose the configuration for testing when we built more than one config.
|
janb84
left a comment
There was a problem hiding this comment.
Concept ACK 3502107
This PR removes setting environment variables for the util test runner in the execution of the test and set the environment variables in more uniform way.
But isn't this PR superseded by PR #32697 which removes the test and therefor the need to make this adjustment ? (it's not merged yet but the PR links to this PR as a conflicting PR)
Correct, the other pr was created to fix all issues in one go, instead of having to go through them one-by-one. |
|
Given #32697 already has a number of ACKs, I think we can just close this. |
When using multi-config CMake generators, executable paths include per-config subdirectories, which require special handling in tests. Using dedicated environment variables to specify executable paths works well in such scenarios. However, the
util_test_runnertest sets these variables for theutil/test_runner.pyscript unconditionally, which diverges from the approach used when runningfunctional/test_runner.py.This change makes the usage of the aforementioned environment variables uniform.
Also see: #32183 (comment).