[28.x] Backports #31648
[28.x] Backports #31648
Conversation
Github-Pull: bitcoin#31611 Rebased-From: b537a2c
This change resolves an issue where a missing space caused the value of
the `build_AR` variable to be concatenated with the "NM=" string. This
resulted in subsequent calls to `${AR}` and `${NM}` failing.
Github-Pull: bitcoin#31627
Rebased-From: 8a46286
…p2p_msgs Inspired by: 00c1dbd (bitcoin#31419) Github-Pull: bitcoin#31623 Rebased-From: f93f0c9
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31648. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
#31623 is a clean merge to both branches, so no need for a cherry-pick here |
248a95f to
77c13c7
Compare
willcl-ark
left a comment
There was a problem hiding this comment.
ACK 77c13c7d3e68464555c6e9a049782674bcd9ea67
All commits look good to me.
I guess the commit title "[WIP] Update release notes" gets updated later during finalisation?
|
@willcl-ark I've just changed it here. |
stickies-v
left a comment
There was a problem hiding this comment.
ACK 2c372fcd5fe4f38aafa7095b990b8b805ee41ab7
All backports are clean, except;
Backports seem sensible.
nit:
- #31611 missing from PR description
- dd32974dda0782798bf0e0b61f32aef745302663 doesn't have the
Github-PullandRebased-Frommetadata - commit authors 0xB10C and kehiy missing from release notes
Github-Pull: bitcoin#31500 Rebased-From: f89f168
willcl-ark
left a comment
There was a problem hiding this comment.
ACK 2c372fcd5fe4f38aafa7095b990b8b805ee41ab7
willcl-ark
left a comment
There was a problem hiding this comment.
ACK e57359c
Now with nits addressed.
Backports:
libeventpackage on NetBSD #31500MINmacro to_TRACEPOINT_TEST_MINin log_raw_p2p_msgs #31623