[28.x] Finalize 28.1 #31582
Closed
[28.x] Finalize 28.1 #31582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31582. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
glozow
reviewed
Jan 2, 2025
| define(_CLIENT_VERSION_RC, 2) | ||
| define(_CLIENT_VERSION_RC, 0) | ||
| define(_CLIENT_VERSION_IS_RELEASE, true) | ||
| define(_COPYRIGHT_YEAR, 2024) |
Member
There was a problem hiding this comment.
I think no code from 2025 was backported, so this seems fine to keep as-is for now.
Member
|
lgtm ACK 898db48 |
Member
|
There are still things tagged for backport for 28.x that haven't been backported. |
Member
Fixed in #31594 |
Member
Author
|
Closing in favor of #31594 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.