test: fix TestShell initialization for cmake build directory #31510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmake build system creates a
build/directory and writesconfig.inithere, along with a tree of symlinks totest_frameworkand all the individual test files. This symlink breaks the fix in #30714 which resolved those symlinks, causing theTestShellto initialize in the original test directory, whereconfig.inidoes not exist.The fix in this patch is simply not to resolve the symlinks, so
TestShelluses:/path/to/bitcoin/build/test/config.ini/path/to/bitcoin/build/test/cacheNote that any arguments like
configfileandcachedirthat are passed tosetup()will be too late to work around the issue since the constructorTestShell()is invoked with a file path first and that path determines config file and cache location.Test script:
Fails on master: