-
Notifications
You must be signed in to change notification settings - Fork 38.7k
depends: fix for llvm-ranlib (etc): 'No such file or directory' macOS 15.0 #30994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/30994. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
|
Not sure about this issue, or making this change. Looks like it needs more investigation. See my comment here: #30978 (comment). |
Yes, switched to draft until we have a better understanding of the issue. |
See #30978 (comment). |
32aba7e to
ba06659
Compare
ba06659 to
7982b95
Compare
|
Rebased and updated the description. The errors are now suppressed by setting a flag for make in the |
|
There hasn't been much activity lately. What is the status here? Finding reviewers may take time. However, if the patch is no longer relevant, please close this pull request. If the author lost interest or time to work on this, please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future. |
|
Is this still needed after #30978 (comment) ? |
This is an attempt to fix the issue #30978 .
To briefly summarize, @Sjors found that while compiling dependencies on macOS 15.0 the following "No such file or directory" are generated while these tools are installed.
The proposed fix conditionally defines the necessary variables for these tools in the./depends/Makefilewhen building on macOS. The rationale is described in more detail in #30978 (comment) as the Solution number 3.Update 1:
It turns out that Xcode's make is not setting the flags that Gnu does as @hebasto described in #30978 (comment). So, to avoid any architectural changes in the
dependsdirectory that may lead to more confusion, the current patch manually sets the required flag in order for the above errors to be resolved.cc @hebasto