lint: Add missing docker.io prefix to ci/lint_imagefile#30501
Merged
fanquake merged 2 commits intobitcoin:masterfrom Jul 22, 2024
Merged
lint: Add missing docker.io prefix to ci/lint_imagefile#30501fanquake merged 2 commits intobitcoin:masterfrom
fanquake merged 2 commits intobitcoin:masterfrom
Conversation
added 2 commits
July 22, 2024 17:27
No need to download and store more than that.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
l0rinc
approved these changes
Jul 22, 2024
hebasto
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
ci/lint_imagefilemay pick the wrong (non-native) architecture due to the missing prefix.For example, assuming the user has previously pulled an s390x image:
Now,
debian:bookwormwill refer to the same image:However,
docker.io/debian:bookwormworks fine:(Also includes a nit-fix from #30499 (comment))