Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented May 1, 2024

It has been this case since the linter was introduced years ago. Given a misunderstanding (#28074 (comment)), clarify the docs.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 1, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label May 1, 2024
@maflcko maflcko force-pushed the 2405-lint-win-crlf- branch from 3ef5bcd to fa9be2f Compare May 1, 2024 06:13
Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa9be2f

@laanwj
Copy link
Member

laanwj commented May 1, 2024

Yes, this makes sense, having a mix of linux and windows line endings in the respository would be a mess.

@fanquake fanquake merged commit 59b773f into bitcoin:master May 2, 2024
@maflcko maflcko deleted the 2405-lint-win-crlf- branch May 2, 2024 08:42
@bitcoin bitcoin locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants