[PoC] qt, depends: Add wayland support without build-time nor fixed run-time deps #29959
Conversation
Doesn't cause problems because we don't use FT on windows, but leave it alone just to be sure.
We don't use the libinput platform, and we don't really care about it (it's for very low level embedded devices use, which render on the screen without windowing env). Remove unnecessary code from the patch.
No need to defer this, simplifies initialization.
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Concept ACK on this. Obviously :) |
2339d21 to
d21b27e
Compare
d21b27e to
82ed822
Compare
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
Closing for now. It exists as a PoC, if anyone is truly interested in wayland support in bitcoin core's binary releases, and interested in helping test and review, let me know. Right now, it seems something people mostly ask about just to ask about. |
i'm not sure. Pretty sure it's something that people will open new issues about endlessly and then forget about them. Might as well leave this one open so there's context. |
I'm sorry for not paying attention to this great PR. I just don't have time to focus on it at the moment. It is about to be changed soon :) |
|
Thank you. To be clear that wasn't aimed at you. i know you're busy enough. Just at the wider FOSS community, who are always full of talk about the next big thing but when push comes to shove (heck, just trying some code is often too much)... In any case we can pick this up at some point. #29923 is basically complete so this would be the next step in the particular progression. |
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a
bitcoin-qtbinary that "just works" on systems that have only one of them installed, or both.Everything (including libEGL) is loaded dynamically at run time if needed.
(
libdl.so.1also when building with older GLIBC, as for guix)When launching with
WAYLAND_DISPLAY=...(takes priority):When launching with
DISPLAY=...:Will make this a draft. This is not ready for review: the Qt patch can potentially be cleaned up a lot with regard to generated wayland code. But it works. Please review #29923 instead, which needs to go in first anyway.
Closes #19950.
qtsowrapwayland branch: https://github.com/laanwj/qtsowrap/tree/waylandCo-authored-by: Hennadii Stepanov
Notes
qtwayland-...is missing while runningmakeindepends, remove thedepends/sources/.download-stamps/.*qt*files to make sure it re-attempts to download missing files.