test: Add large aligned vmov check for mingw #29874
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
Add a check for 32-byte (256 bit) and 64-byte (512 bit) aligned AVX memory accesses (vmova instructions), which cause issues combined with a GCC stack alignment bug on Windows. This check is added to the existing symbol-check.py. Makes use of the capstone disassembler library. Also add a test to test the behavior of the check on a series of assembly instructions against the expected output. Closes bitcoin#28413.
60d11eb to
c21e680
Compare
|
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
|
Looks like |
That's good to know! i'm not that surprised, it's a very popular library for doing binary analysis and reverse engineering kind of things. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
Closing for now. |
Add a check for 32-byte (256-bit) and 64-byte (512-bit) aligned AVX memory accesses (vmova instructions), which cause issues combined with a GCC stack alignment bug on Windows. This check is added to the existing symbol-check.py.
Makes use of the capstone disassembler library.
Also add a test to test the behavior of the check on a series of assembly instructions against the expected output.
Closes #28413.