Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jan 31, 2024

Currently the AU tests only check that loading a txout set with only coinbase outputs works.

Fix that by adding other transactions.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 31, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK jamesob, glozow
Concept ACK mzumsande, BrandonOdiwuor

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #26045 (rpc: Optimize serialization disk space of dumptxoutset by aureleoules)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@mzumsande mzumsande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, I did something very similar locally when investigating #29261.

@jamesob
Copy link
Contributor

jamesob commented Feb 1, 2024

Concept ACK

@jamesob
Copy link
Contributor

jamesob commented Feb 1, 2024

ACK fa5cd66

@DrahtBot DrahtBot requested a review from mzumsande February 1, 2024 20:37
Copy link
Contributor

@BrandonOdiwuor BrandonOdiwuor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

@maflcko
Copy link
Member Author

maflcko commented Feb 5, 2024

rfm?

Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK fa5cd66

@glozow glozow merged commit cd3683c into bitcoin:master Feb 5, 2024
@maflcko maflcko deleted the 2401-test-au-tx- branch February 5, 2024 14:57
@bitcoin bitcoin locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants