Policy: Report debug message why inputs are non standard #29060

ismaelsadeeq · 2023-12-12T13:16:05Z

This PR is another attempt at #13525.

Transactions that fail PreChecks Validation due to non-standard inputs now returns invalid validation stateTxValidationResult::TX_INPUTS_NOT_STANDARD along with a debug error message.

Previously, the debug error message for non-standard inputs do not specify why the inputs were considered non-standard.
Instead, the same error string, bad-txns-nonstandard-inputs, used for all types of non-standard input scriptSigs.

This PR updates the AreInputsStandard to include the reason why inputs are non-standard in the debug message.
This improves the Precheck debug message to be more descriptive.

Furthermore, I have addressed all remaining comments from #13525 in this PR.

DrahtBot · 2023-12-12T13:16:09Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/29060.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	sedited
Concept ACK	stickies-v
Stale ACK	sipa

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#34124 (refactor: make CCoinsView a purely virtual abstract base class by l0rinc)
#33645 (refactor: optimize: avoid allocations in script & policy verification by Raimo33)
#32317 (kernel: Separate UTXO set access from validation functions by sedited)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

LLM Linter (✨ experimental)

Possible places where named args for integral literals may be used (e.g. func(x, /*named_arg=*/0) in C++, and func(x, named_arg=0) in Python):

AddCoins(coins, CTransaction(txFrom), 0) in src/test/script_p2sh_tests.cpp
AddCoins(coins, CTransaction(tx_create), 0, false) in src/test/transaction_tests.cpp
AddCoins(coins, CTransaction(tx_create_p2pk), 0, false) in src/test/transaction_tests.cpp
AddCoins(coins, CTransaction(tx_create_segwit), 0, false) in src/test/transaction_tests.cpp

If you want, I can propose the exact comment-style annotations to make these third/fourth literal arguments clearer (e.g., /height=/0, /coinbase=/false).

^2025-12-30

stickies-v

Concept ACK

src/policy/policy.cpp

src/test/script_p2sh_tests.cpp

src/validation.cpp

src/bench/ccoins_caching.cpp

src/policy/policy.h

src/validation.cpp

src/policy/policy.cpp

ismaelsadeeq · 2023-12-14T11:49:39Z

Thank you for review @stickies-v

I Addressed your comments and taken suggestions.
Force pushed from 6ffb956 to e032462 , Compare diff

src/policy/policy.cpp

ismaelsadeeq · 2023-12-18T15:00:13Z

Thanks for reviewing @luke-jr
Force pushed from e032462 to 0a39b07

Compare diff

The changes in latest push are:

Rebased on master to fix CI
Updated the non-standardness reason to address @luke-jr comments
bad-txns-input-script-nonstandard --> bad-txns-input-script-unknown
bad-txns-input-scriptsig-failure --> bad-txns-input-p2sh-scriptsig-malformed
bad-txns-input-p2sh-no-redeemscript --> bad-txns-input-scriptcheck-missing
bad-txns-input-scriptcheck-sigops --> bad-txns-input-p2sh-redeemscript-sigops

src/policy/policy.h

ismaelsadeeq · 2024-01-30T12:36:27Z

Rebased on master for green CI.

src/validation.cpp

sedited

Concept ACK

There are also some drahtbot llm linter suggestions.

src/policy/policy.cpp

src/test/script_p2sh_tests.cpp

sipa · 2025-10-14T13:50:46Z

Concept ACK on more descriptive error messages.

However, I'm not convinced about changing the error code string from "bad-txns-nonstandard-inputs" to be more granular. My thinking is that the error code is for software to make automated decisions based on, and the more detailed message is for humans to help debugging. In this case, it seems to me just changing the debugging suffices, or do we expect applications to deal differently with different forms of non-standardness.

Somewhat related question: are there places where only the error code is reported, and not the more detailed message?

ismaelsadeeq · 2025-10-14T17:10:19Z

Forced push from db5c7ed388a8eb72247dff015bbf47654f27faf1 to 9eea72d3f3647197c24329b412c7fc71895e3ea2 Compare diff 4f27faf1..9eea72d

I addressed @sipa recent #29060 (comment) by maintained the error code "bad-txns-nonstandard-inputs" and add the additional information in the debug message.

Somewhat related question: are there places where only the error code is reported, and not the more detailed message?

After a grep of GetRejectReason It seems the trace point only reports the reject reason in AcceptToMemoryPool.

src/policy/policy.cpp

sipa

utACK 9eea72d3f3647197c24329b412c7fc71895e3ea2

sedited

ACK 9eea72d3f3647197c24329b412c7fc71895e3ea2

src/policy/policy.cpp

ismaelsadeeq · 2025-11-28T13:15:45Z

Forced push from 9eea72d3f3647197c24329b412c7fc71895e3ea2 to 65d45ac 9eea72d3f3...65d45acf283

Fixed a nit see Policy: Report debug message why inputs are non standard #29060 (comment)
Removed incomplete accounting of the sigop limit because we bailout immediately the limit is reached Policy: Report debug message why inputs are non standard #29060 (comment)

src/policy/policy.cpp

This commit renames AreInputsStandard to ValidateInputsStandardness. ValidateInputsStandardness now returns valid TxValidationState if all inputs (scriptSigs) use only standard transaction forms else returns invalid TxValidationState which states why an input is not standard.

…ring - Test the various input scriptSig non standardness, and ensure ValidateInputsStandardness Returns the reason why the input is nonstandard. Co-authored-by: Ben Woosley <ben.woosley@gmail.com>

sedited

Re-ACK b4db7f3

DrahtBot added the TX fees and policy label Dec 12, 2023

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 3fc397a to 6ffb956 Compare December 12, 2023 13:48

DrahtBot added CI failed and removed CI failed labels Dec 12, 2023

stickies-v reviewed Dec 13, 2023

View reviewed changes

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 6ffb956 to e032462 Compare December 14, 2023 11:43

DrahtBot mentioned this pull request Dec 15, 2023

refactor: Simply include CTxMemPool::Options in CTxMemPool directly rather than duplicating definition #29086

Merged

luke-jr suggested changes Dec 17, 2023

View reviewed changes

src/policy/policy.cpp Outdated Show resolved Hide resolved

src/policy/policy.cpp Outdated Show resolved Hide resolved

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from e032462 to 814571b Compare December 18, 2023 14:53

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 814571b to 0a39b07 Compare December 18, 2023 15:46

glozow reviewed Dec 20, 2023

View reviewed changes

src/policy/policy.h Outdated Show resolved Hide resolved

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch 2 times, most recently from d9e71f0 to 5ef3f9b Compare December 24, 2023 14:41

DrahtBot added the CI failed label Jan 16, 2024

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 5ef3f9b to f4c1945 Compare January 25, 2024 23:05

DrahtBot removed the CI failed label Jan 26, 2024

achow101 requested review from glozow and luke-jr April 9, 2024 15:37

ismaelsadeeq requested a review from stickies-v April 24, 2024 14:30

DrahtBot added the Needs rebase label May 15, 2024

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from f4c1945 to 101a308 Compare May 17, 2024 08:00

DrahtBot removed the Needs rebase label May 17, 2024

luke-jr reviewed May 31, 2024

View reviewed changes

src/validation.cpp Outdated Show resolved Hide resolved

DrahtBot added the CI failed label Sep 11, 2024

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 101a308 to 3ef7ac6 Compare September 14, 2024 11:51

DrahtBot removed the CI failed label Sep 14, 2024

sedited reviewed Oct 11, 2025

View reviewed changes

src/policy/policy.cpp Outdated Show resolved Hide resolved

src/test/script_p2sh_tests.cpp Outdated Show resolved Hide resolved

src/test/script_p2sh_tests.cpp Outdated Show resolved Hide resolved

src/test/script_p2sh_tests.cpp Show resolved Hide resolved

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 85c6c97 to db5c7ed Compare October 13, 2025 12:19

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from db5c7ed to 9eea72d Compare October 14, 2025 16:59

ismaelsadeeq changed the title ~~Policy: Report reason inputs are non standard~~ Policy: Report debug message why inputs are non standard Oct 14, 2025

sipa reviewed Oct 15, 2025

View reviewed changes

src/policy/policy.cpp Outdated Show resolved Hide resolved

sipa reviewed Oct 15, 2025

View reviewed changes

DrahtBot requested a review from sedited October 15, 2025 13:35

DrahtBot mentioned this pull request Oct 17, 2025

refactor: optimize: avoid allocations in script & policy verification #33645

Open

This was referenced Oct 28, 2025

ci, iwyu: Treat warnings as errors for src/init and src/policy #33725

Closed

refactor: make script Solver's often-unused solutions parameter optional #33757

Closed

DrahtBot mentioned this pull request Nov 23, 2025

Align legacy script policy with P2SH policy in AreInputsStandard #33926

Closed

sedited approved these changes Nov 27, 2025

View reviewed changes

maflcko reviewed Nov 27, 2025

View reviewed changes

src/policy/policy.cpp Outdated Show resolved Hide resolved

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch 2 times, most recently from 1eb0b09 to 32a5a84 Compare November 28, 2025 13:09

DrahtBot added the CI failed label Nov 28, 2025

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 32a5a84 to 65d45ac Compare November 28, 2025 13:13

DrahtBot removed the CI failed label Nov 28, 2025

DrahtBot mentioned this pull request Dec 23, 2025

refactor: make CCoinsView a purely virtual abstract base class #34124

Open

sedited reviewed Dec 29, 2025

View reviewed changes

src/policy/policy.cpp Outdated Show resolved Hide resolved

ismaelsadeeq and others added 3 commits December 30, 2025 13:24

test: ensure ValidateInputsStandardness optionally returns debug st…

9b19b41

…ring - Test the various input scriptSig non standardness, and ensure ValidateInputsStandardness Returns the reason why the input is nonstandard. Co-authored-by: Ben Woosley <ben.woosley@gmail.com>

doc: add release notes

b4db7f3

ismaelsadeeq force-pushed the 11-2023-non-standard-inputs-error-messages branch from 65d45ac to b4db7f3 Compare December 30, 2025 13:41

sedited approved these changes Dec 30, 2025

View reviewed changes

DrahtBot requested a review from sipa December 30, 2025 16:12

ismaelsadeeq requested a review from maflcko January 8, 2026 16:57

Policy: Report debug message why inputs are non standard #29060

Are you sure you want to change the base?

Policy: Report debug message why inputs are non standard #29060

Conversation

ismaelsadeeq commented Dec 12, 2023

Uh oh!

DrahtBot commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

LLM Linter (✨ experimental)

Uh oh!

stickies-v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ismaelsadeeq commented Dec 14, 2023

Uh oh!

Uh oh!

Uh oh!

ismaelsadeeq commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ismaelsadeeq commented Jan 30, 2024

Uh oh!

Uh oh!

sedited left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sipa commented Oct 14, 2025

Uh oh!

ismaelsadeeq commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sipa left a comment

Choose a reason for hiding this comment

Uh oh!

sedited left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ismaelsadeeq commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sedited left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

DrahtBot commented Dec 12, 2023 •

edited

Loading

ismaelsadeeq commented Dec 18, 2023 •

edited

Loading

ismaelsadeeq commented Oct 14, 2025 •

edited

Loading

ismaelsadeeq commented Nov 28, 2025 •

edited

Loading