-
Notifications
You must be signed in to change notification settings - Fork 38.7k
refactor: Miniminer package linearization followups #28808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Miniminer package linearization followups #28808
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
This diff appears to have added new lines with trailing whitespace. diff --git a/src/test/miniminer_tests.cpp b/src/test/miniminer_tests.cpp
@@ -696 +695 @@ BOOST_FIXTURE_TEST_CASE(manual_ctor, TestChain100Setup)
|
b21f2f2 to
cec3cfc
Compare
Changes MiniMinerMempoolEntry order to match the order of the params elsewhere in the codebase
Refactored a variable name to be less confusing
cec3cfc to
89c1468
Compare
|
murchandamus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 89c146874175f8481c59436813ccf52a177a8664
This does address the comments I left on the prior PR #28762, and the conflicting PR appears to still be a draft. Looks cleaner and easier to understand to me, but also not particularly urgent.
89c1468 to
b4b01d3
Compare
murchandamus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial fix of my nit and improved formatting of the corresponding comment.
reACK b4b01d3
theStack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ACK b4b01d3
|
@kevkevinpal (nit) in the future, it's best to delete the help text before you open the PR as it gets pulled into the merge commit |
Motivation
In #28762 there were some post merge comments which are being addressed in this PR with the following commits
8d4c46f Reorganizing
MiniMinerMempoolEntryto match the order we have elsewhere7505ec2 Renaming
cached_descendantstodescendantsfor simpler variable namingb21f2f2 Code comment modifications to be more accurate to what is actually happening