refactors for subpackage evaluation #28758
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
f60560b to
6432d24
Compare
6432d24 to
80cd897
Compare
This allows IsSorted() and IsConsistent() to be used by themselves. IsSorted() with a precomputed set is used so that we don't create this set multiple times.
-BEGIN VERIFY SCRIPT- sed -i 's/CheckPackage(/IsWellFormedPackage(/g' $(git grep -l CheckPackage) -END VERIFY SCRIPT-
…, signal BIP125 Support the creation of a transaction with multiple specified inputs or outputs. Also accept a target feerate and return the fee paid. Also, signal BIP125 by default - a subsequent commit needs to RBF something. Co-authored-by: Andrew Chow <achow101@gmail.com>
Avoid duplicate code. This will be used at the end of every AcceptSubPackage and after PreChecks loop in AcceptPackage.
80cd897 to
b5a60ab
Compare
glozow
left a comment
There was a problem hiding this comment.
I started going down the path of making Package a class and these member functions, but it touched hundreds of loc and made it really awkward to try to use it within AncestorPackage when we're checking if subsets are sorted
| // This function checks consistency based on inputs, and we can't do that if there are | ||
| // no inputs. Duplicate empty transactions are also not consistent with one another. | ||
| // This doesn't create false negatives, as unconfirmed transactions are not allowed to | ||
| // have no inputs. |
There was a problem hiding this comment.
“as unconfirmed transactions are not allowed to have no inputs at consensus validation (see CheckTransaction)"
This is part of #27463. It splits off the more trivial changes from #26711 for ease of review, as requested in #26711 (comment).
CheckPackagetoIsPackageWellFormedCreateValidTransactionunit test utility to:CleanupTemporaryCoinsinto its own function to be reused later without duplication