Skip to content

Conversation

@fjahr
Copy link
Contributor

@fjahr fjahr commented Oct 4, 2023

This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to feature_assumeutxo which tends to timeout on slower machines.

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 4, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@hebasto
Copy link
Member

hebasto commented Oct 4, 2023

Fixes #28585

This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to feature_assumeutxo which tends to timeout on slower machines.

From this description it follows that #28585 was caused by "slow" CI environment. But timeout in 2400 seconds may point at some else roots of the problem.

@fjahr fjahr mentioned this pull request Oct 4, 2023
@fjahr fjahr changed the title test: Fix assumeutxo timeout, add test case specific default wait timeout test: Add test case specific default wait timeout, use in feature_assumeutxo Oct 4, 2023
@fjahr
Copy link
Contributor Author

fjahr commented Oct 4, 2023

Fixes #28585
This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to feature_assumeutxo which tends to timeout on slower machines.

From this description it follows that #28585 was caused by "slow" CI environment. But timeout in 2400 seconds may point at some else roots of the problem.

Removed the fix note, #28589 is the actual fix

@fanquake
Copy link
Member

fanquake commented Oct 4, 2023

Removed the fix note, #28589 is the actual fix

Can this be closed then?

@fjahr
Copy link
Contributor Author

fjahr commented Oct 4, 2023

I am closing this for now and will reopen if we see more timeouts occur. Could be that the timeouts @achow101 reported were related to #28589.

@fjahr fjahr closed this Oct 4, 2023
@fjahr fjahr mentioned this pull request Oct 4, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants