refactor: Remove WithParams serialization helper, use SER_PARAMS_OPFUNC #28503
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
cc @theuni |
fac9afe to
fa544f8
Compare
|
Concept ACK. |
-BEGIN VERIFY SCRIPT- sed -i 's|WithParams(\([a-zA-Z:._]\+\), |\1(|g' $( git grep -l WithParams ) -END VERIFY SCRIPT-
fa544f8 to
fa664dc
Compare
sedited
left a comment
There was a problem hiding this comment.
ACK fa664dc335f02c392e3268f403f32bcf5bd9eeee
ajtowns
left a comment
There was a problem hiding this comment.
ACK fa664dc335f02c392e3268f403f32bcf5bd9eeee
fa664dc to
9999019
Compare
|
reACK 9999019 |
Every serialization parameter struct already has the
SER_PARAMS_OPFUNC, except for one in the tests.For consistency, and to remove verbose code, convert the test to
SER_PARAMS_OPFUNC, and use it everywhere, then remove theWithParamshelper.