-
Notifications
You must be signed in to change notification settings - Fork 38.7k
test: Wallet interactions with rescanning wallet #26700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
40aa73d to
7caada8
Compare
7caada8 to
5c52dc8
Compare
5c52dc8 to
d77d3a7
Compare
|
This PR seems to generate intermittent failures despite my efforts... |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
| t.daemon = True | ||
| t.start() | ||
|
|
||
| assert_raises_rpc_error(-4, "Wallet is currently rescanning. Abort existing rescan or wait.", self.nodes[0].cli(*command).send_cli) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will race against the thread t, which may have already concluded before this point
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
A new pull can be opened, once and if this is rebased, and the tests pass. |
This pull request tests that interacting with a wallet while rescanning will fail with
Wallet is currently rescanning. Abort existing rescan or wait..I'm running a rescan for each RPC command being tested instead of only one for all to avoid intermittent failures.
Each rescan takes about 2 seconds, enough time to run the tested RPC commands simultaneously.
I added this test in
feature_pruning.pyto use the large chain generated and renamed it tofeature_large_chain.pyas I think it is more appropriate now.