Skip to content

Conversation

@aureleoules
Copy link
Contributor

@aureleoules aureleoules commented Dec 14, 2022

This pull request tests that interacting with a wallet while rescanning will fail with Wallet is currently rescanning. Abort existing rescan or wait..

I'm running a rescan for each RPC command being tested instead of only one for all to avoid intermittent failures.
Each rescan takes about 2 seconds, enough time to run the tested RPC commands simultaneously.
I added this test in feature_pruning.py to use the large chain generated and renamed it to feature_large_chain.py as I think it is more appropriate now.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 14, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

No conflicts as of last run.

@aureleoules aureleoules changed the title rpc: Prevent unloading a wallet when rescanning test: Wallet interactions with rescanning wallet Dec 14, 2022
@aureleoules aureleoules marked this pull request as ready for review January 10, 2023 07:48
@aureleoules
Copy link
Contributor Author

This PR seems to generate intermittent failures despite my efforts...

@aureleoules aureleoules marked this pull request as draft January 25, 2023 12:28
@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

@DrahtBot
Copy link
Contributor

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

  • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
  • Is it no longer relevant? ➡️ Please close.
  • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

t.daemon = True
t.start()

assert_raises_rpc_error(-4, "Wallet is currently rescanning. Abort existing rescan or wait.", self.nodes[0].cli(*command).send_cli)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will race against the thread t, which may have already concluded before this point

@DrahtBot
Copy link
Contributor

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

  • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
  • Is it no longer relevant? ➡️ Please close.
  • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

@maflcko maflcko closed this Aug 21, 2023
@maflcko
Copy link
Member

maflcko commented Aug 21, 2023

A new pull can be opened, once and if this is rebased, and the tests pass.

@bitcoin bitcoin locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants