The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #26609 (refactor: Move txmempool_entry.h --> kernel/mempool_entry.h by hebasto)
• #26441 (rpc, p2p: add addpermissionflags RPC by brunoerg)
• #26261 (p2p: cleanup LookupIntern, Lookup and LookupHost by brunoerg)
• #26114 (net: Make AddrFetch connections to fixed seeds by mzumsande)
• #25619 (net: avoid overriding non-virtual ToString() in CService and use better naming by vasild)
• #25572 (refactor: Introduce EvictionManager and use it for the inbound eviction logic by dergoegge)
• #25515 (net, test: Virtualise CConnman and add initial PeerManager unit tests by dergoegge)
• #25390 (sync: introduce a thread-safe generic container and use it to remove a bunch of "GlobalMutex"es by vasild)
• #25268 (refactor: Introduce EvictionManager by dergoegge)
• #25136 (Torcontrol opt check by amadeuszpawlik)
• #20018 (p2p: ProcessAddrFetch(-seednode) is unnecessary if -connect is specified by dhruv)
• #19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
• #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
• #10102 (Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

🐙 This pull request conflicts with the target branch and needs rebase.

I guess it could still make sense to do a move-only build system change to move proxy/socks out of the bins that don't need it (wallet, util, cli, ...)?

I guess it could still make sense to do a move-only build system change to move proxy/socks out of the bins that don't need it (wallet, util, cli, ...)?

+1

I did that in fa02d16, but I am not sure how useful it is.

Maybe it would make more sense to create a separate net_utils library?