build, qt: drop fix_no_printer patch, add CVE fixes #24688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt 5.15.3 release is a patch release made on the top of Qt 5.15.2. As a patch release, Qt 5.15.3 does not add any new functionality but provides bug fixes and other improvements. https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/5.15.3/release-note.md * dropped patches: - patches/qt/dont_use_avx_android_x86_64.patch - patches/qt/fix_bigsur_style.patch * adjusted patches: - patches/qt/fix_android_jni_static.patch - patches/qt/fix_limits_header.patch - patches/qt/use_android_ndk23.patch Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
The removed patch is not required since switching Qt version from 5.12.11 to 5.15.2.
more info: - https://nvd.nist.gov/vuln/detail/CVE-2022-25255 - https://nvd.nist.gov/vuln/detail/CVE-2022-25634 patches adapted from: - https://download.qt.io/official_releases/qt/5.15/CVE-2022-25255-qprocess5-15.diff - https://download.qt.io/official_releases/qt/5.15/CVE-2022-25643-5.15.diff note: there is a typo in the second upstream patch filename :-/ (should be 25634, is 25643)
This was referenced Mar 27, 2022
Member
|
NACK. I don't understand why all these Qt patch changes are being split into different PRs. If we are going to go through the motions of bumping Qt, then all the changes should be in #24668. |
Contributor
Author
This PR is a combination of all Qt related PRs. If our goal is to have all changes combined, I can just push the same changeset to #24668 and close this PR. |
Member
Yes, lets do that. |
Contributor
Author
Done. Closing this PR. Sorry for the noise. 2 extra commits from this PR pushed to #24668 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.