[23.x] guix: use same commit for codesigning time-machine #24485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time machines should be updated in lockstep. Github-Pull: bitcoin#24484 Rebased-From: 29862bd
hebasto
approved these changes
Mar 6, 2022
Member
hebasto
left a comment
There was a problem hiding this comment.
ACK 0dcbd2e
$ git grep -e '--commit=ae03f401381e956c4c41b4cf495cbde964fa43d0'
contrib/guix/guix-build: --commit=ae03f401381e956c4c41b4cf495cbde964fa43d0 \
contrib/guix/guix-codesign: --commit=ae03f401381e956c4c41b4cf495cbde964fa43d0 \
Member
|
Post-merge ACK. I think going forward it would make sense to store this id in a separate script that gets included into both the build and code signing? |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time machines should be updated in lockstep. Backports #24484.
Github-Pull: #24484
Rebased-From: 29862bd