[22.x] fs: Make compatible with boost 1.78 #24476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#24104 Rebased-From: dc5d6b0
hebasto
reviewed
Mar 5, 2022
| boost::system::error_code error; | ||
| // The canonical path cleans the path, preventing >1 Berkeley environment instances for the same directory | ||
| fs::path canonical_wallet_dir = fs::canonical(wallet_dir, error); | ||
| fs::path canonical_wallet_dir = fs::canonical(wallet_dir, error).remove_trailing_separator(); |
Member
There was a problem hiding this comment.
Why this change is required? I see no broken tests on the current 22.x branch (9b5f674) on macOS 12.2.1 (Apple M1).
Member
There was a problem hiding this comment.
On my system with boost 1.78, the unit tests fail with a trailing backslash in the path here.
Member
|
ACK 021c3d8 |
hebasto
reviewed
Mar 5, 2022
hebasto
approved these changes
Mar 5, 2022
Contributor
|
ACK 021c3d8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #24104 to the
22.xbranch to fix the build with Boost 1.78.0.