build, qt: Fix regression in rendering on macOS Big Sur #23556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mammix2 <mammix2@hotmail.com>
Minimum required libxcb to build qt 5.15.x is 1.11. https://codereview.qt.nokia.com/c/qt/qtbase/+/253905 Some plugins have been re-enabled as they are required by Qt.
Required for xcb_icccm.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Nov 19, 2021
jarolrod
reviewed
Nov 20, 2021
Contributor
jarolrod
left a comment
There was a problem hiding this comment.
Concept ACK, This does in fact fix the regression. It should be documented what the regression is:
Master Depends Build (Qt 5.12)
PR23489 Depends Build (Qt 5.15)
This PR Depends Build (Qt 5.15)
Member
|
Cherry-picked into #23489. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #23489.
The initial support of macOS Big Sur by Qt was pretty broken. Fixup commits were submitted into the
devbranch, and backported to5.12and5.15branches.Those fixups were released with the Qt 5.12.11, but, unfortunately, will be never (?) released as Qt 5.15.3 (for license issues, I guess).
Therefore, bumping Qt version from 5.12.11 to 5.15.2 brings a regression into rendering of some widgets in macOS BigSur.
This PR fixes this regression.
See: