build: Avoid rebuilding makefiles #22486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this commit is to reduce the amount of work make does. This simplifies make -d output and improves performance (this performance gain is hardly noticeable). By default make remakes all makefiles. This build system does not have rules to remake makefiles. This commit adds an explicit rule for each makefile. Each rule serves 2 purposes. 1. Each rule prevents make from searching for an implicit rule. 2. Once found, the rule prevents make from remaking the makefile. That's why the rule is double colon. Make won't use a double colon rule to remake a makefile. See https://www.gnu.org/software/make/manual/make.html#Remaking-Makefiles. $ # on this branch. $ make -d print-host |grep expat Reading makefile 'packages/expat.mk' (search path) (no ~ expansion)... Makefile 'packages/expat.mk' might loop; not remaking it. $ git co master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. $ make -d print-host |grep expat |wc 367 1916 19918 $ Make prints 367 lines per makefile. With this change make prints 2 lines per makefile.
* master: (436 commits) Test that descriptor wallet upgrade does nothing Make IsSegWitOutput return true for taproot outputs bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp Change ScriptPubKeyMan::Upgrade to default to return true test: move rpc_rawtransaction tests to < 30s group test: whitelist rpc_rawtransaction peers to speed up tests test: Fix wallet_listdescriptors.py if bdb is not compiled Move implementations of non-template fuzz helpers refactor: move UpdateTip into CChainState refactor: no mempool arg to GetCoinsCacheSizeState refactor: move UpdateMempoolForReorg into CChainState validation: make CChainState::m_mempool optional init: remove straggling boost thread_group code fix incorrect testmempoolaccept doc doc: mention that we enforce port=0 in I2P addrman: reset I2P ports to 0 when loading from disk test: ensure I2P ports are handled as expected net: do not connect to I2P hosts on port!=0 net: distinguish default port per network net: change I2P seeds' ports to 0 ...
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 19, 2021
Member
|
Concept ACK. It seems this PR should be rebased on top of the recent master branch. |
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Contributor
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
Member
|
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened. cc @dongcarl |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this commit is to reduce the amount of work make does.
This simplifies make -d output and improves performance (this
performance gain is hardly noticeable).
By default make remakes all makefiles.
This build system does not have rules to remake makefiles.
This commit adds an explicit rule for each makefile.
Each rule serves 2 purposes.
$ # on this branch.
$ make -d print-host |grep expat
Reading makefile 'packages/expat.mk' (search path) (no ~ expansion)...
Makefile 'packages/expat.mk' might loop; not remaking it.
$ git co master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ make -d print-host |grep expat |wc
367 1916 19918
$
Make prints 367 lines per makefile.
With this change make prints 2 lines per makefile.
This changeset was originally submitted as pr #22237.
I am closing #22237 and resubmitting the same changeset here.