Skip to content

fuzz: Version handshake #20097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maflcko wants to merge 1 commit into from
Closed

fuzz: Version handshake #20097

maflcko wants to merge 1 commit into from

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Oct 7, 2020

I don't see a reason to exclude the version/verack message from the process_messages fuzzer. Whereas including it will have several benefits:

  • Higher coverage (version/verack/handshake/wtxid/...) in net_processing
  • Fuzzer can pick the peer versions instead of relying on a hardcoded constant, might increase search space and coverage even further

@DrahtBot DrahtBot added the Tests label Oct 7, 2020
@maflcko
Copy link
Member Author

maflcko commented Oct 9, 2020

cc @practicalswift

@maflcko
Copy link
Member Author

maflcko commented Oct 9, 2020

For reference, it is currently impossible to hit meaningfully the following message types in the fuzzer: if (msg_type == NetMsgType::VERSION) {, if (msg_type == NetMsgType::WTXIDRELAY) {. See https://marcofalke.github.io/btc_cov/fuzz.coverage/src/net_processing.cpp.gcov.html

@practicalswift
Copy link
Contributor

practicalswift commented Oct 9, 2020

Thanks for the ping! Will review :)

@maflcko
Copy link
Member Author

maflcko commented Oct 12, 2020

I'll explore some ideas on how to increase coverage even further. Closing for now.

@maflcko maflcko closed this Oct 12, 2020
@maflcko maflcko deleted the 2010-fuzzHandshake branch October 12, 2020 11:23
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maflcko @practicalswift @DrahtBot