wallet: deactivate descriptor #19774
Conversation
|
ACK 4deb2ef |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| { | ||
| WalletLogPrintf("Deactivate spkMan: id = %s, type = %d, internal = %d\n", id.ToString(), static_cast<int>(type), static_cast<int>(internal)); | ||
| WalletBatch batch(*database); | ||
| if (!batch.EraseActiveScriptPubKeyMan(static_cast<uint8_t>(type), internal)) { |
There was a problem hiding this comment.
It's erasing a spkm of the same output type because the user is importing an inactive descriptor of the same output type? Am I reading this right?
There was a problem hiding this comment.
🤦 Yes, unfortunately, you are correct. Another issue is that I can't fix this PR on it's own. I was under impression it can be separate from #19651 but alas. I can't just move EraseActiveScriptPubKeyMan under if (spk_mans[type] && spk_mans[type]->GetID() == id) because the map of active spk managers has been cleared already by this point. So it's impossible to know whether we need to write anything to the disk.
I'll fix this and combine with #19651 where I'm trying to make importdescriptors command do proper updates. Would you mind reviewing that instead?
There was a problem hiding this comment.
ill subscribe to that PR, sure!
|
Closed in favor of #19651 |
Rationale: allow to deactivate wallet descriptor
Currently, it's not possible to deactivate wallet descriptor,
activeargument is just silently ignored if set tofalse. When descriptor is deactivated it's still present in the wallet, but can't be used to derive new addresses.Follow up for #19651