Skip to content

gui: add missing translation.h include to fix build #19231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Jun 10, 2020
Merged

gui: add missing translation.h include to fix build #19231

fanquake merged 1 commit into from
Jun 10, 2020

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jun 10, 2020

After #19176, building the gui on Bionic is failing with:

  CXX      qt/qt_libbitcoinqt_a-guiutil.o
qt/bitcoin.cpp: In function 'int GuiMain(int, char**)':
qt/bitcoin.cpp:460:35: error: 'Untranslated' was not declared in this scope
           node->initError(strprintf(Untranslated("Error parsing command line arguments: %s\n"), error));

The merge commit also failed to compile with the same error:
https://travis-ci.org/github/bitcoin/bitcoin/jobs/696627543

@fanquake
gui: add missing translation.h include to fix build
948f113 
After bitcoin#19176, building the gui on Bionic is failing with:

```bash
  CXX      qt/qt_libbitcoinqt_a-guiutil.o
qt/bitcoin.cpp: In function 'int GuiMain(int, char**)':
qt/bitcoin.cpp:460:35: error: 'Untranslated' was not declared in this scope
node->initError(strprintf(Untranslated("Error parsing command line arguments: %s\n"), error));
```

The merge commit also failed to compile with the same error:
https://travis-ci.org/github/bitcoin/bitcoin/jobs/696627543
@fanquake fanquake added the GUI label Jun 10, 2020
hebasto
hebasto approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 948f113, tested on Linux Mint 19.3 (x86_64): it fixes compiling error with the --disable-wallet configure option.

While testing #19176 I compiled with both GCC and Clang, but did not try the --disable-wallet configure option. Sorry for that.

@fanquake fanquake merged commit 20e9531 into bitcoin:master Jun 10, 2020
@fanquake fanquake deleted the translations_gui_fixup branch June 10, 2020 09:13
@maflcko
Copy link
Member

maflcko commented Jun 10, 2020

I had missed that travis did not run this pull or did not report the result. Travis' only purpose is to compile pull requests and if it doesn't do that, we should remove it.

Screenshot_2020-06-10 refactor Error message bilingual_str consistency by laanwj · Pull Request #19176 · bitcoin bitcoin

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

Assignees

No one assigned

Labels

GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanquake @maflcko @hebasto