Expand on contracting carve-out rule test #18723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Apr 21, 2020
| for _ in range(4): | ||
| # First tx has 3 outputs | ||
| (txid, sent_value) = self.chain_transaction(self.nodes[0], [txid], [vout], value, fee, 3) | ||
| vout = 0 |
Member
There was a problem hiding this comment.
afaict vout is always zero anyway? same for line 63 below...
Member
Author
There was a problem hiding this comment.
removed for line 63, otherwise I think this is more clear personally
| # First tx has 3 outputs | ||
| (txid, sent_value) = self.chain_transaction(self.nodes[0], [txid], [vout], value, fee, 3) | ||
| vout = 0 | ||
| value = sent_value |
Member
There was a problem hiding this comment.
redundant assignment in this loop (and the next one), can remove?
if not, may make sense to extract the loop body to a function
|
|
||
| # But now that we're at the additional carve-out limit, the third base output being spent will be rejected | ||
| # For both ancestor's descendant limits | ||
| assert_raises_rpc_error(-26, "too-long-mempool-chain, too many descendants", self.chain_transaction, self.nodes[0], [chain[0][0]], [2], chain[0][1], fee, 1) |
Member
There was a problem hiding this comment.
"too-long-mempool-chain, too many descendants" used 5x, could hoist to a TOO_MANY_DESCENDANTS constant
c5db55a to
9e653de
Compare
9e653de to
08dce51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the "one more" on top of "one more", making sure this is rejected.