doc: Explain new test logging #18486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa8d687 to
faabce8
Compare
Member
Author
|
Just as a note, if we wanted to remove boost, diff --git a/src/test/main.cpp b/src/test/main.cpp
index f32243d1d3..9bccbef805 100644
--- a/src/test/main.cpp
+++ b/src/test/main.cpp
@@ -13,14 +13,19 @@
#include <iostream>
-/** Redirect debug log to unit_test.log files */
-const std::function<void(const std::string&)> G_TEST_LOG_FUN = [](const std::string& s) {
+bool IsTestLoggingEnabled()
+{
static const bool should_log{std::any_of(
&boost::unit_test::framework::master_test_suite().argv[1],
&boost::unit_test::framework::master_test_suite().argv[boost::unit_test::framework::master_test_suite().argc],
[](const char* arg) {
return std::string{"DEBUG_LOG_OUT"} == arg;
})};
- if (!should_log) return;
+ return should_log;
+}
+
+/** Redirect debug log to unit_test.cpp.log files */
+const std::function<void(const std::string&)> G_TEST_LOG_FUN = [](const std::string& s) {
+ if (!IsTestLoggingEnabled()) return;
std::cout << s;
};
diff --git a/src/test/util/logging.h b/src/test/util/logging.h
index 45ec44173c..f4ad232c6e 100644
--- a/src/test/util/logging.h
+++ b/src/test/util/logging.h
@@ -11,6 +11,13 @@
#include <list>
#include <string>
+bool IsTestLoggingEnabled();
+
+#define TEST_MESSAGE(blob) \
+ if (IsTestLoggingEnabled()) { \
+ std::cout << blob << std::endl; \
+ }
+
class DebugLogHelper
{
const std::string m_message; |
faabce8 to
7777703
Compare
jonatack
reviewed
Mar 31, 2020
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain logging added in #18472 and #16975