Skip to content

gui: Drop BanTableModel dependency to ClientModel #18035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
promag wants to merge 1 commit into from
Closed

gui: Drop BanTableModel dependency to ClientModel #18035

promag wants to merge 1 commit into from

Conversation

@promag
Copy link
Contributor

@promag promag commented Jan 31, 2020

Trivial change since ClientModel is not used by BanTableModel.

@promag promag requested a review from hebasto January 31, 2020 00:15
@fanquake fanquake added the GUI label Jan 31, 2020
jonasschnelli
jonasschnelli approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

utACK 8eec9c7

@promag promag mentioned this pull request Jan 31, 2020
Merged
hebasto
hebasto approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8eec9c7, tested on Linux Mint 19.3

@promag
Copy link
Contributor Author

promag commented Jan 31, 2020

Included in #18036.

@promag promag closed this Jan 31, 2020
@promag promag deleted the 2020-01-bantablemodel branch January 31, 2020 08:20
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

+1 more reviewer

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@promag @jonasschnelli @hebasto @fanquake