IsUsedDestination should count any known single-key address #17621
Conversation
|
cc @kallewoof since you designed the first iteration |
|
Concept ACK Tests please :) |
|
Concept ACK |
90bb5da to
2ca5a16
Compare
|
Pushed test, updated logic to fix test failure. Removed a function that resulted in a used footgun. |
2ca5a16 to
ef4a1a4
Compare
ef4a1a4 to
9f7eea5
Compare
|
ACK 9f7eea56f2b0fbc128b83fccab344190b1e6ce54 Reviewed code and tested locally. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
9f7eea5 to
0950245
Compare
achow101
left a comment
There was a problem hiding this comment.
ACK 9f7eea56f2b0fbc128b83fccab344190b1e6ce54
test/functional/wallet_avoidreuse.py
Outdated
There was a problem hiding this comment.
It would be, once address type default is changed, no?
| const CScript& scriptPubKey = out.tx->tx->vout[out.i].scriptPubKey; | ||
| bool fValidAddress = ExtractDestination(scriptPubKey, address); | ||
| bool reused = avoid_reuse && pwallet->IsUsedDestination(address); | ||
| bool reused = avoid_reuse && pwallet->IsUsedDestination(out.tx->GetHash(), out.i); |
There was a problem hiding this comment.
nit, you could move this line after L2932 - no point in calling IsUsedDestination if this address doesn't matter.
meshcollider
left a comment
There was a problem hiding this comment.
Code Review ACK 0950245
|
Being backported in 17792. |
This plugs the privacy leak detailed at #17605, at least for the single-key case.