refactoring: Use direct list initialization for Arg struct #16469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @ryanofsky @promag |
promag
reviewed
Jul 26, 2019
| LOCK(cs_args); | ||
| std::map<std::string, Arg>& arg_map = m_available_args[cat]; | ||
| auto ret = arg_map.emplace(name.substr(0, eq_index), Arg(name.substr(eq_index, name.size() - eq_index), help, debug_only)); | ||
| auto ret = arg_map.emplace(name.substr(0, eq_index), Arg{name.substr(eq_index, name.size() - eq_index), help, debug_only}); |
Contributor
There was a problem hiding this comment.
Can't test at the moment but I think you could drop Arg?
Member
Author
There was a problem hiding this comment.
Can't test at the moment but I think you could drop
Arg?
It won't work if a type is automatically deduced: auto ret = ...
Member
There was a problem hiding this comment.
I'd prefer to keep it. Three ascii chars are not a bloat
maflcko
reviewed
Jul 26, 2019
| { | ||
| std::string m_help_param; | ||
| std::string m_help_text; | ||
| bool m_debug_only; |
Member
There was a problem hiding this comment.
Can those be const to enforce setting them in the constructor?
| LOCK(cs_args); | ||
| std::map<std::string, Arg>& arg_map = m_available_args[cat]; | ||
| auto ret = arg_map.emplace(name.substr(0, eq_index), Arg(name.substr(eq_index, name.size() - eq_index), help, debug_only)); | ||
| auto ret = arg_map.emplace(name.substr(0, eq_index), Arg{name.substr(eq_index, name.size() - eq_index), help, debug_only}); |
Member
There was a problem hiding this comment.
I'd prefer to keep it. Three ascii chars are not a bloat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a direct list initialization for
struct Argobjects makes the constructor needless.This PR has been split out from #16097 (see: #16097 (comment)).