Skip to content

netbase: Remove "tor" as a network specification #16029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dongcarl wants to merge 1 commit into from
Closed

netbase: Remove "tor" as a network specification #16029

dongcarl wants to merge 1 commit into from

Conversation

@dongcarl
Copy link
Contributor

@dongcarl dongcarl commented May 15, 2019 

"tor" as a network specification was deprecated in 60dc8e4208 in favor
of "onion" and this commit removes it and updates the relevant test.

@dongcarl dongcarl mentioned this pull request May 15, 2019
Merged
Empact
Empact reviewed May 15, 2019
View reviewed changes
@dongcarl dongcarl force-pushed the 2019-05-remove-net-tor branch from 31521f3 to 4fda32f Compare May 15, 2019 18:21
@dongcarl
netbase: Remove "tor" as a network specification
4fda32f 
"tor" as a network specification was deprecated in 60dc8e4 in favor
of "onion" and this commit removes it and updates the relevant test.
@laanwj
Copy link
Member

laanwj commented May 16, 2019

I don't think there's any hurry to do this.

What happens after this change if a user provides -onlynet=tor, please don't tell me it's silently ignored?

@fanquake
Copy link
Member

fanquake commented May 17, 2019

@laanwj

What happens after this change if a user provides -onlynet=tor, please don't tell me it's silently ignored?

With this change, running src/bitcoind --onlynet=tor will abort at startup:

2019-05-17T07:05:08Z init message: Loading banlist...
2019-05-17T07:05:08Z Error: Unknown network specified in -onlynet: 'tor'
Error: Unknown network specified in -onlynet: 'tor'
2019-05-17T07:05:08Z Shutdown: In progress...
2019-05-17T07:05:08Z scheduler thread interrupt
2019-05-17T07:05:08Z Shutdown: done

@jonatack
Copy link
Member

jonatack commented May 17, 2019 •
edited
Loading

FWIW the deprecation warning this PR would remove was added more recently with #13532 than the 2014 commit 60dc8e4208 mentioned in the PR description above.

@dongcarl
Copy link
Contributor Author

dongcarl commented May 17, 2019

@jonatack Right. It seems like this was effectively deprecated in 60dc8e4208 but users would only have known about it with #13532. Closing, but perhaps we could add a release note item about the deprecation so more people know about it in case we decide to remove it in the future.

@dongcarl dongcarl closed this May 17, 2019
@laanwj
Copy link
Member

laanwj commented May 18, 2019 

 With this change, running src/bitcoind --onlynet=tor will abort at startup:

That's good at least.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
@fanquake
Copy link
Member

fanquake commented Dec 8, 2025

Picked up in #34031.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Empact Empact Empact left review comments

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

P2P Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dongcarl @laanwj @fanquake @jonatack @Empact @maflcko @DrahtBot